Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Side Github OAuth 컴포넌트 및 API 구현 (#19) #41

Merged
merged 9 commits into from
Nov 10, 2022

Conversation

shyuuuuni
Copy link
Collaborator

@shyuuuuni shyuuuuni commented Nov 10, 2022

요약

새로운 기능

  • Profile 컴포넌트와 하위 컴포넌트인 NotLoggedInProfile, UserProfile 컴포넌트 구현
  • /apis/auth.ts 에서 로그인, 로그아웃, 토근 재발급 API 함수 작성
  • axios 인터셉터 설정으로 요청 전 유저 토큰 만료 확인 및 재발급 요청 로직 추가

환경 설정

  • vite 환경에 절대경로 설정

연관 이슈

Pull Request 체크리스트

TODO

  • 최종 결과물을 확인했는가?
  • 의미 있는 커밋 메시지를 작성했는가?

Copy link
Member

@NaamuKim NaamuKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hooks로 분리해서 사용하니 확실히 로직 구분이 잘되고 재사용성도 좋네요!
너무 고생많으셨고 popup쪽 hook만 확인 부탁드립니다!

client/vite.config.ts Show resolved Hide resolved
client/src/hooks/useOAuthPopup.tsx Show resolved Hide resolved
client/src/hooks/useOAuthPopup.tsx Outdated Show resolved Hide resolved
Copy link
Member

@NaamuKim NaamuKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍
수정 확인했고 고생하셨습니다!

@NaamuKim NaamuKim merged commit 89fc450 into dev Nov 10, 2022
@NaamuKim NaamuKim deleted the feature/#19-github-ouath-component branch November 10, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants