-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client Side Github OAuth 컴포넌트 및 API 구현 (#19) #41
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OAuth api 추가후 token refresh handler 추가하였습니다.
로그인이 되어 있으면 UserProfile 컴포넌트를, 되어 있지 않으면 NotLoggedInProfile 컴포넌트를 보여주도록 구현함
NaamuKim
requested changes
Nov 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hooks로 분리해서 사용하니 확실히 로직 구분이 잘되고 재사용성도 좋네요!
너무 고생많으셨고 popup쪽 hook만 확인 부탁드립니다!
client/src/components/Profile/NotLoggedInProfile/NotLoggedInProfile.scss
Show resolved
Hide resolved
NaamuKim
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍
수정 확인했고 고생하셨습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약
새로운 기능
Profile
컴포넌트와 하위 컴포넌트인NotLoggedInProfile
,UserProfile
컴포넌트 구현/apis/auth.ts
에서 로그인, 로그아웃, 토근 재발급 API 함수 작성axios
인터셉터 설정으로 요청 전 유저 토큰 만료 확인 및 재발급 요청 로직 추가환경 설정
연관 이슈
Pull Request 체크리스트
TODO