add certificate verifying in ssl client examples #1237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 27, 2018 19:36
Verify remote server's certificate
Verify remote server's certificate
remove duplicated root certificate pem string
|
Why are removing that one certificate? Also what about the websocket clients? |
|
Here should be a loop, add one authority once. |
Codecov Report
@@ Coverage Diff @@
## develop #1237 +/- ##
===========================================
- Coverage 95.52% 95.51% -0.01%
===========================================
Files 113 113
Lines 11064 11064
===========================================
- Hits 10569 10568 -1
- Misses 495 496 +1
Continue to review full report at Codecov.
|
vinniefalco
pushed a commit
to vinniefalco/beast
that referenced
this pull request
Sep 23, 2018
fix boostorg#1237 HTTP client examples now verify the server's certificate and generate an error if the certificate is invalid or expired: * Set certificate verify mode * Remove duplicate root certificate
vinniefalco
pushed a commit
to vinniefalco/beast
that referenced
this pull request
Sep 23, 2018
fix boostorg#1237 HTTP client examples now verify the server's certificate and generate an error if the certificate is invalid or expired: * Set certificate verify mode * Remove duplicate root certificate
vinniefalco
pushed a commit
to vinniefalco/beast
that referenced
this pull request
Sep 23, 2018
fix boostorg#1237 HTTP client examples now verify the server's certificate and generate an error if the certificate is invalid or expired: * Set certificate verify mode * Remove duplicate root certificate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify the remote servers' certificates in the ssl examples.