Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set parser status and flags even if body_limit_ has been reached #1556

Closed
wants to merge 1 commit into from

Conversation

medelh
Copy link
Contributor

@medelh medelh commented Apr 4, 2019

Parsing the header of a request that is larger than 1 MB prevents the setting of body_limit and reading the request body

@vinniefalco
Copy link
Member

Seems reasonable, thanks! This will have to go into the develop branch for now, as the Boost 1.70 release is closed (and about to ship). After the release I can merge it to master, but it will not be available in the official Boost distribution until Boost 1.71.

@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #1556 into develop will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1556   +/-   ##
========================================
  Coverage    92.63%   92.63%           
========================================
  Files          150      150           
  Lines        12131    12131           
========================================
  Hits         11237    11237           
  Misses         894      894
Impacted Files Coverage Δ
include/boost/beast/http/impl/basic_parser.ipp 93.55% <33.33%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b701d72...5233260. Read the comment docs.

@vinniefalco
Copy link
Member

@medelh your username and email are not configured locally (using git config) so the commit is not linked to your GitHub account, is this intended?

vinniefalco added a commit to vinniefalco/beast that referenced this pull request Apr 8, 2019
@medelh
Copy link
Contributor Author

medelh commented Apr 8, 2019

@medelh your username and email are not configured locally (using git config) so the commit is not linked to your GitHub account, is this intended?

not really, it was by mistake. Can it still be set?

@vinniefalco
Copy link
Member

not really, it was by mistake. Can it still be set?

Yes, it can - and I would prefer that you are properly credited for the contribution. You just need to use git config to set your username and email to match the credentials on your GitHub account, amend the commit locally, and then force-push it to your fork - this will update the pull request automatically.

@medelh
Copy link
Contributor Author

medelh commented Apr 8, 2019

Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants