Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make chat websocket javascript client more user friendly #1611

Conversation

podsvirov
Copy link
Contributor

One image instead of 1000 words:

make-chat-client-more-user-friendly

And I saved 60 lines of code.

@codecov
Copy link

codecov bot commented May 18, 2019

Codecov Report

Merging #1611 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1611   +/-   ##
========================================
  Coverage    92.66%   92.66%           
========================================
  Files          151      151           
  Lines        12132    12132           
========================================
  Hits         11242    11242           
  Misses         890      890

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1dabeb...ec7f571. Read the comment docs.

@vinniefalco
Copy link
Member

Very nice, thanks!

@podsvirov podsvirov deleted the make-chat-client-more-user-friendly branch May 24, 2019 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants