Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix C++20 incompatibilities in IO extensions #617

Merged

Conversation

fmorgner
Copy link
Contributor

Description

Replace the simple-template-ids used in the IO extension tags as constructor names for specializations of image_read_info and image_read_settings with the associated plain class names.

References

resolves #616

Tasklist

  • Ensure all CI builds pass
  • Review and approve

@sdebionne
Copy link
Contributor

LGTM and thanks for the fix! I remember asking myself what were this image_read_info< xxx_tag >() ctor about but they were armless at the time.

@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #617 (effd078) into develop (7dd6120) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #617   +/-   ##
========================================
  Coverage    78.72%   78.72%           
========================================
  Files          118      118           
  Lines         5034     5034           
========================================
  Hits          3963     3963           
  Misses        1071     1071           

@fmorgner
Copy link
Contributor Author

I believe the build issues in CI / windows (msvc-14.2, 14,17,latest, 32,64, windows-2019) are the same as on the develop branch, while CI / posix (clang, clang++-9, 11,14,17,2a, ubuntu-20.04) seems to have an issue with a missing clang-9 installation.

@sdebionne
Copy link
Contributor

From what I read on slack, the GHA guys have fun changing the docker images without notice. I am not a CI guru, @mloskot can this be easily fixed? Apparently develop currently fails with the same error with clang-8/clang-9.

@sdebionne
Copy link
Contributor

@mloskot I'd like to merge this one, any objection?

Copy link
Member

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@mloskot
Copy link
Member

mloskot commented Oct 4, 2021

@sdebionne Please, do. Thank you for nudging me about it.

Sorry, I have no having any solution for the CI issues right now. I should be able to look at that next month.

@sdebionne
Copy link
Contributor

@mloskot No worries and unfortunately I don't have time to look at the CI neither... but this should be safe to merge.

@sdebionne sdebionne merged commit c9b339e into boostorg:develop Oct 5, 2021
@sdebionne sdebionne added this to the Boost 1.78+ milestone Oct 31, 2021
@mloskot mloskot mentioned this pull request May 12, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility with C++20
4 participants