Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CMake test config #634

Merged
merged 1 commit into from Feb 9, 2022
Merged

Refactor CMake test config #634

merged 1 commit into from Feb 9, 2022

Conversation

lpranam
Copy link
Member

@lpranam lpranam commented Dec 30, 2021

Description

I don't think we need multiple loops here unless I am missing something? @simmplecoder

References

Tasklist

  • Add test case(s)
  • Ensure all CI builds pass
  • Review and approve

simmplecoder
simmplecoder approved these changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@simmplecoder simmplecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there is no need for two loops. I believe I did it to just separate my work from Miral's, but there is no need for that anymore.

mloskot
mloskot approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpranam lpranam merged commit 1995201 into boostorg:develop Feb 9, 2022
@lpranam lpranam deleted the cmake_test branch February 9, 2022 14:17
@mloskot mloskot added config/cmake Any issues about CMake configuration test New tests development or missing tests issues, no new functionality labels Feb 9, 2022
@mloskot mloskot mentioned this pull request May 12, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloskot mloskot mloskot approved these changes

@simmplecoder simmplecoder simmplecoder approved these changes

@meshtag meshtag meshtag approved these changes

Assignees
No one assigned
Labels
config/cmake Any issues about CMake configuration test New tests development or missing tests issues, no new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lpranam @mloskot @simmplecoder @meshtag