Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the health checker more flexible #104

Open
mzimbres opened this issue May 20, 2023 · 0 comments
Open

Make the health checker more flexible #104

mzimbres opened this issue May 20, 2023 · 0 comments

Comments

@mzimbres
Copy link
Collaborator

At the moment if the response to a health-check does not come under the time specified by the user, the connection will timeout. This is not flexible enough to deal with e.g. heavy load where the specified interval cannot be honored because e.g. it is processing too many pushes.

We can offer two options to users

  1. Inflexible checks: The connection times out if the specified interval is not honored. (Current implementation)
  2. Flexibel checks: Any incoming data, like server pushes are seen as a proof of health (and not only the response to a health-check).

Option 2. covers my own needs, we might not need option 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant