Boost 1.74 cannot compile simple example with serialization/set.hpp #219

fcooper8472 · 2020-09-08T16:48:55Z

Including boost/serialization/set.hpp does not compile:

#include <boost/serialization/set.hpp>

int main() {
    return 0;
}

the following error is produced:

/celibs/boost_1_74_0/boost/serialization/set.hpp: In function 'void boost::serialization::load_set_collection(Archive&, Container&)':

/celibs/boost_1_74_0/boost/serialization/set.hpp:40:33: error: 'library_version_type' in namespace 'boost::serialization' does not name a type; did you mean 'item_version_type'?

   40 |     const boost::serialization::library_version_type library_version(

      |                                 ^~~~~~~~~~~~~~~~~~~~

      |                                 item_version_type

/celibs/boost_1_74_0/boost/serialization/set.hpp:47:30: error: 'library_version_type' is not a member of 'boost::serialization'; did you mean 'item_version_type'?

   47 |     if(boost::serialization::library_version_type(3) < library_version){

      |                              ^~~~~~~~~~~~~~~~~~~~

      |                              item_version_type

/celibs/boost_1_74_0/boost/serialization/set.hpp:47:56: error: 'library_version' was not declared in this scope

   47 |     if(boost::serialization::library_version_type(3) < library_version){

      |                                                        ^~~~~~~~~~~~~~~

ASM generation compiler returned: 1

In file included from <source>:1:

/celibs/boost_1_74_0/boost/serialization/set.hpp: In function 'void boost::serialization::load_set_collection(Archive&, Container&)':

/celibs/boost_1_74_0/boost/serialization/set.hpp:40:33: error: 'library_version_type' in namespace 'boost::serialization' does not name a type; did you mean 'item_version_type'?

   40 |     const boost::serialization::library_version_type library_version(

      |                                 ^~~~~~~~~~~~~~~~~~~~

      |                                 item_version_type

/celibs/boost_1_74_0/boost/serialization/set.hpp:47:30: error: 'library_version_type' is not a member of 'boost::serialization'; did you mean 'item_version_type'?

   47 |     if(boost::serialization::library_version_type(3) < library_version){

      |                              ^~~~~~~~~~~~~~~~~~~~

      |                              item_version_type

/celibs/boost_1_74_0/boost/serialization/set.hpp:47:56: error: 'library_version' was not declared in this scope

   47 |     if(boost::serialization::library_version_type(3) < library_version){

      |                                                        ^~~~~~~~~~~~~~~

Execution build compiler returned: 1

This is not a problem pre-1.74.

The text was updated successfully, but these errors were encountered:

robertramey · 2020-09-08T18:02:05Z

OK - I fixed this one the develop branch. Should migrate to master on next release. Thanks for catching this!

fcooper8472 · 2020-09-09T10:01:49Z

Great, thanks for fixing!

jagerman · 2020-09-16T16:28:47Z

I also get this failure from boost/serialization/list.hpp, but the fix on master looks like it only applies to set.hpp. (Looking at the include dir, I think slist.hpp also needs it added).

robertramey · 2020-09-16T17:08:35Z

right - will do. Are there any others?

fcooper8472 · 2020-09-16T17:45:47Z

Just gone through to check which headers when included on their own produce compilation errors (with g++-10):

#include <boost/serialization/boost_unordered_map.hpp>
#include <boost/serialization/boost_unordered_set.hpp>
#include <boost/serialization/hash_collections_load_imp.hpp>
#include <boost/serialization/list.hpp>
#include <boost/serialization/set.hpp>
#include <boost/serialization/slist.hpp>
#include <boost/serialization/unordered_collections_load_imp.hpp>
#include <boost/serialization/unordered_map.hpp>
#include <boost/serialization/unordered_set.hpp>

The following headers each produced the following error:

#include <boost/serialization/hash_collections_save_imp.hpp>
#include <boost/serialization/hash_map.hpp>
#include <boost/serialization/hash_set.hpp>

error: 'version' was not declared in this scope
...

The following header produces the following error:

#include <boost/serialization/optional.hpp>

error: 'version' is not a class template
...

Finally, there's a file:

boost/serialization/collection_size_type copy.hpp

that looks a bit suspect.

robertramey · 2020-09-27T06:00:01Z

I believe these are fixed. BUT I haven't run the tests you've run. So you should run them again.

I didn't get the comment "boost/serialization/collection_size_type copy.hpp" so there may be something to do in that area.

To summarize, this should be better, but somehow I don't think we're quite done yet. Ideally I'd like to add a bunch of tests for this so the problem can never happen again. Using B2 these would be "compile only". I don't remember how it would be done for CMake. In any case, it would be quite a number of tests. I'm not sure I'm up for this.

fcooper8472 · 2020-09-28T11:26:14Z

@robertramey just that there are both:

boost/serialization/collection_size_type.hpp
boost/serialization/collection_size_type copy.hpp

and the latter is the only header with a " copy" in it, and wondered if it was supposed to be there at all. The contents of the file are substantially different, but it doesn't seem to be referenced anywhere.

The library seems to compile happily without it (although I see the header files are being found using file(GLOB ...) in CMake which not recommended.

I'm unable to compile the tests though (see errors below which I don't have time right now to chase down), so I can't be certain whether or not that functionality is being used anywhere.

/usr/bin/ld: libwserialization.so: undefined reference to `boost::archive::detail::utf8_codecvt_facet::utf8_codecvt_facet(unsigned long)'

robertramey · 2020-09-28T15:32:49Z

On 9/28/20 4:26 AM, Fergus Cooper wrote: @robertramey <https://github.com/robertramey> just that there are both: |boost/serialization/collection_size_type.hpp boost/serialization/collection_size_type copy.hpp | and the latter is the only header with a " copy" in it, and wondered if it was supposed to be there at all. The contents of the file are substantially different, but it doesn't seem to be referenced anywhere.

Ahh - I see this now. You're right. It isn't used. It should be removed. BUT since it's different than the other one I should do a little history checking just in case.

The library seems to compile happily without it (although I see the header files are being found using |file(GLOB ...)| in CMake which not recommended <https://cmake.org/cmake/help/latest/command/file.html#filesystem>.

I'm aware that this is not recommended. But I plead that this is an exceptional case. The number of headers is very large and handling them one by one would be very tedious and error prone. So I'll leave this as it is.

I'm unable to compile the tests though (see errors below which I don't have time right now to chase down), so I can't be certain whether or not that functionality is being used anywhere. |/usr/bin/ld: libwserialization.so: undefined reference to `boost::archive::detail::utf8_codecvt_facet::utf8_codecvt_facet(unsigned long)'|

|this has often been a pain point. I'm not sure what to suggest. I don't have a magic bullet answer.|

|| — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#219 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAPBDXHGH4O4H5ZRXAPLVJLSIBXGJANCNFSM4RAHRJXQ>.

-- Robert Ramey www.rrsd.com (805)569-3793

An extra header may now be required for Boost 1.74. See boostorg/serialization#219 and, for example, jngrad/espresso@a392907 .

…ostorg/serialization#219

This <boost/serialization/library_version_type.hpp> include guards against an issue in boost::serialization from boost 1.74.0 that leads to compiler error "'library_version_type' is not a member of 'boost::serialization'" when including <boost/serialization/unordered_map.hpp>. More details in ticket boostorg/serialization#219

MatheusJulidori · 2022-05-27T17:30:22Z

Seems to be happening again after ubuntu 22.04 update

Tried to make a file and this error was launched:

/usr/include/boost/serialization/unordered_collections_load_imp.hpp:51:27: error: ‘library_version_type’ is not a member of ‘boost::serialization’; did you mean ‘item_version_type’?
   51 |     boost::serialization::library_version_type library_version(
      |                           ^~~~~~~~
      |                           item_version_type
/usr/include/boost/serialization/unordered_collections_load_imp.hpp:57:30: error: ‘library_version_type’ is not a member of ‘boost::serialization’; did you mean ‘item_version_type’?
   57 |     if(boost::serialization::library_version_type(3) < library_version){
      |                              ^~~~~~~~
      |                              item_version_type
/usr/include/boost/serialization/unordered_collections_load_imp.hpp:57:56: error: ‘library_version’ was not declared in this scope; did you mean ‘SSLeay_version’?
   57 |     if(boost::serialization::library_version_type(3) < library_version){

chrischarlesharrison · 2022-07-12T18:15:44Z

I can confirm Matheus' issue with a fresh install of Ubuntu 22.

This fixes issues with Boost versions See `boostorg/serialization#219

pavel-odintsov · 2023-03-07T12:54:51Z

I've used this bugfix jngrad/espresso@f33faf0 for our project and it worked just fine pavel-odintsov/fastnetmon@c0d0454

Jonas-Wessner · 2023-09-03T03:08:41Z

I still get the following error with boost 1.74 which I have just freshly installed with apt-get a couple of minutes ago on Ubuntu 22.04.

/usr/include/boost/serialization/set.hpp:40:33: error: ‘library_version_type’ in namespace ‘boost::serialization’ does not name a type; did you mean ‘item_version_type’?
   40 |     const boost::serialization::library_version_type library_version(
      |                                 ^~~~~~~~~~~~~~~~~~~~

robertramey · 2023-09-03T19:24:03Z

I've totally lost track of this. Current version looks OK to see. So I'm going to close this issue. Fee free to re-open (again) or make a new issue(better)

fallaha · 2023-09-06T14:42:31Z

I can confirm this issue (library_version_type) with a fresh install of Ubuntu 22.

robertramey · 2023-09-06T16:58:49Z

Thinking about this. Let's assume for now that this issue is only present in Boost 1.74. And suppose we found it and had a fix. Then what would we do? The release date is August 2020. Would be go back an update the Boost 1.74 package? Somehow I doubt it. My suggestion would be to:

verify if the same issue occurs in the current release.
If not - do nothing
if it does - fix it in the current release
Recommend to users who experience this issue to upgrade the most recent release

fallaha · 2023-09-06T17:54:16Z

OK, but how can I update it in UBUNTU 22.04 apt package manager?
can't you update it in UBUNTU repository?

robertramey · 2023-09-06T17:56:32Z

Sorry, I don't know all the vagaries of boost distribution.

Jonas-Wessner · 2023-09-07T07:29:34Z

The issue is that the problem exists in the currently by apt delivered version. (1.74).
Building and installing from source is a nightmare if you are on a laptop since it will take many hours.
Anyways, I just made this comment because I think a bug report is in general valuable information. If you don't want to use it, then don't. I also understand that fixing a bug in an old software version is not prioritized.

angelinesalberto · 2023-09-29T11:06:39Z

I have the same problem with boost-1.82.0 and rocky

/mnt/lustre/home/spack/spack/opt/spack/linux-rocky8-icelake/gcc-8.5.0/boost-1.82.0-v2eykt7r24sm77j3d3lcr7r6qfe4pe3m//include/boost/property_tree/ptree_serialization.hpp:66:24: error: 'library_version_type' in namespace 'bsa' does not name a type
const bsa::library_version_type library_version(
^~~~~~~~~~~~~~~~~~~~
/mnt/lustre/home/spack/spack/opt/spack/linux-rocky8-icelake/gcc-8.5.0/boost-1.82.0-v2eykt7r24sm77j3d3lcr7r6qfe4pe3m//include/boost/property_tree/ptree_serialization.hpp:69:21: error: 'library_version_type' is not a member of 'bsa'
if(bsa::library_version_type(3) < library_version){
^~~~~~~~~~~~~~~~~~~~
/mnt/lustre/home/spack/spack/opt/spack/linux-rocky8-icelake/gcc-8.5.0/boost-1.82.0-v2eykt7r24sm77j3d3lcr7r6qfe4pe3m//include/boost/property_tree/ptree_serialization.hpp:69:21: note: suggested alternative:
In file included from /mnt/lustre/home/spack/spack/opt/spack/linux-rocky8-icelake/gcc-8.5.0/boost-1.82.0-v2eykt7r24sm77j3d3lcr7r6qfe4pe3m//include/boost/serialization/vector.hpp:28,
from ../../../../src/util/serialization.h:39,
from ../../../../src/util/input/input.h:31,
from ../../../../src/util/input/input.cc:27:
/mnt/lustre/home/spack/spack/opt/spack/linux-rocky8-icelake/gcc-8.5.0/boost-1.82.0-v2eykt7r24sm77j3d3lcr7r6qfe4pe3m//include/boost/serialization/library_version_type.hpp:36:7: note: 'boost::serialization::library_version_type'
class library_version_type {
^~~~~~~~~~~~~~~~~~~~
In file included from ../../../../src/util/serialization.h:46,
from ../../../../src/util/input/input.h:31,
from ../../../../src/util/input/input.cc:27:
/mnt/lustre/home/spack/spack/opt/spack/linux-rocky8-icelake/gcc-8.5.0/boost-1.82.0-v2eykt7r24sm77j3d3lcr7r6qfe4pe3m//include/boost/property_tree/ptree_serialization.hpp:69:47: error: 'library_version' was not declared in this scope
if(bsa::library_version_type(3) < library_version){
^~~~~~~~~~~~~~~
/mnt/lustre/home/spack/spack/opt/spack/linux-rocky8-icelake/gcc-8.5.0/boost-1.82.0-v2eykt7r24sm77j3d3lcr7r6qfe4pe3m//include/boost/property_tree/ptree_serialization.hpp:69:47: note: suggested alternative: 'item_version'
if(bsa::library_version_type(3) < library_version){
^~~~~~~~~~~~~~~
item_version

fcooper8472 closed this as completed Sep 9, 2020

fcooper8472 reopened this Sep 16, 2020

This was referenced Oct 21, 2020

blockchain: deterministic UNIX time unlock checks /monero#6745 aeonix/aeon#201

Merged

prepare for v0.14.1.0 aeonix/aeon-gui#48

Merged

ProfFan mentioned this issue Nov 2, 2020

Feature/wrap sfm data borglab/gtsam#569

Merged

hdclark pushed a commit to hdclark/Ygor that referenced this issue Dec 10, 2020

Support for Boost::Serialization 1.74.

70525b9

An extra header may now be required for Boost 1.74. See boostorg/serialization#219 and, for example, jngrad/espresso@a392907 .

hdclark pushed a commit to hdclark/DICOMautomaton that referenced this issue Dec 10, 2020

Support for Boost::Serialization 1.74.

515aa6b

An extra header may now be required for Boost 1.74. See boostorg/serialization#219 and, for example, jngrad/espresso@a392907 .

ghost mentioned this issue Dec 23, 2020

The windows build error is due to MinGW using Boost 1.74 which has some flaws: https://github.com/boostorg/serialization/issues/219 aeonix/aeon#204

Closed

deniskristak pushed a commit to deniskristak/easybuild-easyconfigs that referenced this issue Jan 15, 2021

patch of a missing include file. this bug has been fixed in 1.75.0 bo…

269fa1f

…ostorg/serialization#219

deniskristak pushed a commit to deniskristak/easybuild-easyconfigs that referenced this issue Jan 15, 2021

patch of a missing include file. this bug has been fixed in 1.75.0 bo…

69490b3

…ostorg/serialization#219

boegel mentioned this issue Jan 15, 2021

add patch for Boost 1.74.0 to fix missing include file easybuilders/easybuild-easyconfigs#12007

Merged

rjoomen mentioned this issue Jun 4, 2022

Build failure on Ubuntu 22.04 tesseract-robotics/tesseract#764

Closed

one-and-only added a commit to swap-dev/swap that referenced this issue Dec 28, 2022

Pin Ubuntu runner version to 20.04

ae41562

This fixes issues with Boost versions See `boostorg/serialization#219

berndpfrommer mentioned this issue Jan 25, 2023

ubuntu nightly build fails with error: ‘library_version_type’ is not a member of ‘boost::serialization’ borglab/gtsam#1412

Closed

This was referenced Aug 5, 2023

Update: Add conditional include for newer boost libraries Soldann/MORB_SLAM#93

Closed

Add conditional include for newer boost libraries DavidPetkovsek/MORB_SLAM#24

Closed

robertramey closed this as completed Sep 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Boost 1.74 cannot compile simple example with serialization/set.hpp #219

Boost 1.74 cannot compile simple example with serialization/set.hpp #219

fcooper8472 commented Sep 8, 2020

robertramey commented Sep 8, 2020

fcooper8472 commented Sep 9, 2020

jagerman commented Sep 16, 2020

robertramey commented Sep 16, 2020

fcooper8472 commented Sep 16, 2020

robertramey commented Sep 27, 2020

fcooper8472 commented Sep 28, 2020

robertramey commented Sep 28, 2020 via email

MatheusJulidori commented May 27, 2022

chrischarlesharrison commented Jul 12, 2022

pavel-odintsov commented Mar 7, 2023

Jonas-Wessner commented Sep 3, 2023

robertramey commented Sep 3, 2023

fallaha commented Sep 6, 2023

robertramey commented Sep 6, 2023

fallaha commented Sep 6, 2023

robertramey commented Sep 6, 2023

Jonas-Wessner commented Sep 7, 2023 •

edited

Loading

angelinesalberto commented Sep 29, 2023

Boost 1.74 cannot compile simple example with serialization/set.hpp #219

Boost 1.74 cannot compile simple example with serialization/set.hpp #219

Comments

fcooper8472 commented Sep 8, 2020

robertramey commented Sep 8, 2020

fcooper8472 commented Sep 9, 2020

jagerman commented Sep 16, 2020

robertramey commented Sep 16, 2020

fcooper8472 commented Sep 16, 2020

robertramey commented Sep 27, 2020

fcooper8472 commented Sep 28, 2020

robertramey commented Sep 28, 2020 via email

MatheusJulidori commented May 27, 2022

chrischarlesharrison commented Jul 12, 2022

pavel-odintsov commented Mar 7, 2023

Jonas-Wessner commented Sep 3, 2023

robertramey commented Sep 3, 2023

fallaha commented Sep 6, 2023

robertramey commented Sep 6, 2023

fallaha commented Sep 6, 2023

robertramey commented Sep 6, 2023

Jonas-Wessner commented Sep 7, 2023 • edited Loading

angelinesalberto commented Sep 29, 2023

Jonas-Wessner commented Sep 7, 2023 •

edited

Loading