Setting color_output=no does not disable the output of color format codes

[Markus87]

I think --color_output=no should not just use the default color for everything, it should stop color format codes from being outputted completely. The current behaviour is very misleading to me.

test/include/boost/test/utils/setcolor.hpp

Line 304 in 35c9acf

is_color_output ? utils::attr : utils::term_attr::NORMAL, \

To understand why it is a problem let me describe my test setup:
I use ctest to run boost tests and instructed ctest to output everything to a file.
The file contains all color codes that boost writes, --color_output=yes/no only changes if its all the same color or not, the codes remain any way.

[toonetown]

Agreed. This also happens when trying to run unit tests within Xcode's debugger windows (which doesn't support ANSI colors).

I was able to work around it (in my particular case) by tweaking the #define BOOST_TEST_SCOPE_SETCOLOR. I added these lines before including my main unit test headers:

#include <boost/test/utils/setcolor.hpp>
#undef BOOST_TEST_SCOPE_SETCOLOR
#define BOOST_TEST_SCOPE_SETCOLOR(is_color_output, os, attr, color)

That basically just disables ansi color altogether.

[toonetown]

IMO, I think that if you say --enable_color=no, it should completely skip the ansi codes altogether.

[toonetown]

A proposed patch can be found at #154

[raffienficiaud]

Closed through PR #154