New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When specifying --color_output=no, don't output color codes #154

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
2 participants
@toonetown
Contributor

toonetown commented Aug 30, 2018

As described in #149, specifying --color_output=no still will output the color codes, it just outputs the codes for "normal" output.

A better approach would be if the user disables color output completely, the codes should not be included at all. This PR attempts to do that.

@raffienficiaud

This comment has been minimized.

Member

raffienficiaud commented Sep 3, 2018

Thanks, merged to develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment