New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows - Spurious timing test failures on windows. #133

Closed
garyfurnish opened this Issue Aug 27, 2017 · 7 comments

Comments

Projects
None yet
2 participants
@garyfurnish

garyfurnish commented Aug 27, 2017

Related to Trac 9856 in test_9856

The fact that Thread doesn't return timeout up to 10% of the time on Windows is wontfix.

Can we at least change the threshold for the test on windows so that we don't get spurious failures?

This was tested in 3222938.

@viboes

This comment has been minimized.

Show comment
Hide comment
@viboes

viboes Aug 28, 2017

Collaborator

Could you tell me on which platform and compiler you got the issue? are those run in http://www.boost.org/development/tests/develop/developer/thread.html?

Collaborator

viboes commented Aug 28, 2017

Could you tell me on which platform and compiler you got the issue? are those run in http://www.boost.org/development/tests/develop/developer/thread.html?

@viboes viboes added the bug label Aug 28, 2017

@garyfurnish

This comment has been minimized.

Show comment
Hide comment
@garyfurnish

garyfurnish Aug 28, 2017

This is on Windows 10 insiders with Visual Studio 17.4 Preview. I think it was also failing on 17.3 on windows 10, but I can't guarantee that. I could rerun with regular 17.3. This is a 4/8 sandy bridge machine. (More detailed specs in other bugs). This persisted seemingly independent of system load.

garyfurnish commented Aug 28, 2017

This is on Windows 10 insiders with Visual Studio 17.4 Preview. I think it was also failing on 17.3 on windows 10, but I can't guarantee that. I could rerun with regular 17.3. This is a 4/8 sandy bridge machine. (More detailed specs in other bugs). This persisted seemingly independent of system load.

@viboes viboes changed the title from Spurious timing test failures on windows. to VS 2017.4 Preview Spurious timing test failures on windows. Aug 28, 2017

@viboes

This comment has been minimized.

Show comment
Hide comment
@viboes

viboes Aug 28, 2017

Collaborator

Could you tell me which % threshold is good for Windows?

I don't know, maybe it isn't worth running this test.

Collaborator

viboes commented Aug 28, 2017

Could you tell me which % threshold is good for Windows?

I don't know, maybe it isn't worth running this test.

@viboes viboes changed the title from VS 2017.4 Preview Spurious timing test failures on windows. to windows - Spurious timing test failures on windows. Aug 28, 2017

@garyfurnish

This comment has been minimized.

Show comment
Hide comment
@garyfurnish

garyfurnish Aug 28, 2017

If I run it alone the highest I've gotten was 13.8% and 15% might be a reasonable target.
If I use b2 -j8 (num hyperthreads) to run the tests then it can go at least 38.2%, maybe higher. I suspect this test will always fail if run in parallel with other tests. Run alone its probably reasonable.

garyfurnish commented Aug 28, 2017

If I run it alone the highest I've gotten was 13.8% and 15% might be a reasonable target.
If I use b2 -j8 (num hyperthreads) to run the tests then it can go at least 38.2%, maybe higher. I suspect this test will always fail if run in parallel with other tests. Run alone its probably reasonable.

@viboes viboes added enhancement and removed bug labels Aug 28, 2017

@viboes

This comment has been minimized.

Show comment
Hide comment
@viboes

viboes Aug 28, 2017

Collaborator

I guess that the testers are using -jx

I will set the threshold to 40% :(

Collaborator

viboes commented Aug 28, 2017

I guess that the testers are using -jx

I will set the threshold to 40% :(

@viboes

This comment has been minimized.

Show comment
Hide comment
@viboes

viboes Aug 28, 2017

Collaborator
Collaborator

viboes commented Aug 28, 2017

@garyfurnish

This comment has been minimized.

Show comment
Hide comment
@garyfurnish

garyfurnish Aug 28, 2017

Tests clean under load, closing as fixed.

garyfurnish commented Aug 28, 2017

Tests clean under load, closing as fixed.

@viboes viboes added the boost-1.66 label Sep 19, 2017

@viboes viboes added this to the 1.66 milestone Oct 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment