Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproducible builds ruin time_conversion_helper #181

Open
realazthat opened this issue Nov 17, 2022 · 2 comments
Open

Reproducible builds ruin time_conversion_helper #181

realazthat opened this issue Nov 17, 2022 · 2 comments

Comments

@realazthat
Copy link

I use bazel as my build system, and bazel specializes in reproducible builds, which basically means it tries to build everything in a sandbox with limited access to system libraries, and replaces the various date macros with some string like REDACTED . This breaks the time_conversion_helper and asserts(false) at runtime.

not sure what the best solution is, but it would be great if there was a macro that made the time-based macros optional.

My solution is to fork boost and comment out the assertion (

BOOST_ASSERT(0 != compile_time);
).

@jefftrull
Copy link
Collaborator

It looks like the purpose of this code is to help produce version strings for Wave itself (including its samples). I think it might be fine to produce UNKNOWN as a string in cases where parsing fails, instead of doing this assert. We'd need some test cases too to ensure valid date/time strings didn't start getting misparsed.

@jefftrull
Copy link
Collaborator

Another idea: I read about SOURCE_DATE_EPOCH; if we offered a setting that would help you implement that (i.e. by overriding system time) would that suffice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants