Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to pretty 0.1.34 #355

Closed
hlship opened this issue Dec 16, 2015 · 8 comments
Closed

Update to pretty 0.1.34 #355

hlship opened this issue Dec 16, 2015 · 8 comments

Comments

@hlship
Copy link
Contributor

hlship commented Dec 16, 2015

pretty 0.1.20 adds support for Clojure 1.8; specifically, support for deep-linked functions.

For these "imported" libraries, it would be nice if there was a single place to check to see what version is effectively incorporated.

@micha
Copy link
Contributor

micha commented Dec 17, 2015

@hlship Thanks for the heads up! You're right about the versions, perhaps adding them to the namespace meta would be good? Like this perhaps:

(ns boot.from.io.aviso.ansi
  {:boot/from :AvisoNovate/pretty:0.1.20
   :doc "Help with generating textual output that includes ANSI escape codes for formatting."}

@Deraen
Copy link
Contributor

Deraen commented Dec 17, 2015

Eventually it would also be good to use some more automated way to handle these libraries. Either by 1) moving them to boot.pod boot.worker deps, if possible, 2) by using mranderson (with lein, has some problems though for our use) or 3) with some Boot task which would copy files from defined maven deps and rename them.

@micha micha added the ready label Jul 30, 2016
@hlship
Copy link
Contributor Author

hlship commented Oct 24, 2016

I may work on this on friday (our "fun day").

@hlship
Copy link
Contributor Author

hlship commented Oct 24, 2016

Is the fact that current Pretty changes the order of output going to be a problem? Basically, normal Java stack traces are backwards (each successive line is further back in time). More recent versions of pretty invert this by default. Basically, clojure.main at the top of the stack trace, your.task.here at the bottom.

@arichiardi
Copy link
Contributor

Personally I have always preferred the relevant info on the bottom in the console, so good for me 😄

@martinklepsch
Copy link
Member

Pretty is at 0.1.34 now — anyone interested in updating this in Boot?

Equally worthwhile work would be the inlining boot task Juho mentioned above.

@martinklepsch martinklepsch changed the title update to pretty 0.1.20 [2.5] Update to pretty 0.1.34 Dec 21, 2017
@burn2delete
Copy link
Contributor

I got this one 😉

@martinklepsch
Copy link
Member

PR opened #670

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants