Fixes #617: Add simple template processor in jar :file.

[jgrzebyta]

• accepts version and project templates

Signed-off-by: Jacek Grzebyta jgrzebyta@users.noreply.github.com

[Deraen]

Lein uses format for these, and only supports using version: :jar-name "hello-%.jar".
Maven supports properties: <file>foo-${foo.version}</file>.

I think copying Lein behaviour would be sensible, unless there is a good reason to also support project name?

[jgrzebyta]

What about making separate - uberised - jar? In maven user might compile normal jar or the executable '-with-dependencies' one. Does your solution require having separate build file with different project name? Best regards, Jacek

…

On 26 Sep 2017 6:23 p.m., "Juho Teperi" ***@***.***> wrote: Lein uses format for these, and only supports using version: :jar-name "hello-%.jar". Maven supports properties: <file>foo-${foo.version}</file>. I think copying Lein behaviour would be sensible, unless there is a good reason to also support project name? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#618 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGbRXBn13C6t0t-2gj4-YODz5xPOKk2Qks5smTMJgaJpZM4N8SXe> .

[alandipert]

I think we're not really comparable to either lein or maven in this case, since we're programmable. The user can easily fill a template string in their build.boot based on strings they define and pass as arguments to tasks, which could also be the strings used to generate the pom.

That said, I see no reason not to do this, even if its arguably going against the grain in our model. It's backward compatible and can save some typing. 👍

@Deraen if you are OK with it too please feel free to merge when you see this.

[martinklepsch]

I don't like it too much that this goes "against the grain" as Alan already noted but the complexity is within reason so I'm ok to merge it.

There are some potential NPEs if I'm not mistaken, with some particularly bad error messages if the user makes a typo in his pattern. It would be great to see those addressed before merging 🙂

[martinklepsch]

(string/replace nil ,,,)

This will throw, no?

[martinklepsch]

The replacement function seems a bit hard to read and will throw if an unknown pattern is provided.
Maybe something like the following could be used?

(fn [[_ group]]
  (case group 
    "project" (name project)
    "version" version
    (do (util/warn "Unknown pattern {%s} in jar task's :file option\n" group)
        (str "{" group "}")))))

This will provide a helpful message if the user makes a typo instead of this:

NullPointerException   java.util.regex.Matcher.quoteReplacement (Matcher.java:701)

For readability the replacement function could also be put into it's own local var or even in a top-level defn-.

[martinklepsch]

@jgrzebyta are you planning to get back to this or should it be closed? 🙂

[jgrzebyta]

@martinklepsch I will close this PR.

[martinklepsch]

Ok! Thanks for your efforts! 💛