Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully serialize pod return values before pr-str'ing #684

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

martinklepsch
Copy link
Member

Fix for #683.

I added a test as well but lein test isn't working. Will need to look into that.

Copy link
Contributor

@arichiardi arichiardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pod is the only test which doesn't use boot.test. Maybe we can convert it like in #579?

@@ -465,7 +466,9 @@
([expr]
(let [{:keys [meta? expr]} (read-string expr)]
(binding [*print-meta* meta?]
(pr-str (eval expr)))))
(->> (eval expr)
(walk/postwalk identity) ; make sure all lazy seqs are realized #683
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arichiardi
Copy link
Contributor

If we merge #685 in then this can use it 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants