Skip to content

perf: move repetitive plugin code to plugin.js #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 57 commits into from
Nov 5, 2017
Merged

Conversation

tmorehouse
Copy link
Member

Should help with improved minification

@codecov-io
Copy link

codecov-io commented Nov 4, 2017

Codecov Report

Merging #1285 into dev will decrease coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1285      +/-   ##
==========================================
- Coverage   42.44%   42.22%   -0.22%     
==========================================
  Files         130      130              
  Lines        2721     2638      -83     
  Branches      858      816      -42     
==========================================
- Hits         1155     1114      -41     
+ Misses       1252     1210      -42     
  Partials      314      314
Impacted Files Coverage Δ
src/components/embed/index.js 100% <100%> (+25%) ⬆️
src/components/nav/index.js 100% <100%> (+20%) ⬆️
src/components/table/index.js 100% <100%> (+25%) ⬆️
src/components/popover/index.js 100% <100%> (+25%) ⬆️
src/components/media/index.js 100% <100%> (+25%) ⬆️
src/components/carousel/index.js 100% <100%> (+25%) ⬆️
src/components/badge/index.js 100% <100%> (+25%) ⬆️
src/directives/popover/index.js 100% <100%> (+25%) ⬆️
src/components/form-select/index.js 100% <100%> (+25%) ⬆️
src/components/form-radio/index.js 100% <100%> (+25%) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 037ad08...eda5219. Read the comment docs.

@tmorehouse tmorehouse changed the title [WIP] perf: move repetitive plugin code to plugin.js perf: move repetitive plugin code to plugin.js Nov 4, 2017
@tmorehouse tmorehouse merged commit 6ba8c46 into dev Nov 5, 2017
@tmorehouse tmorehouse deleted the tmorehouse/plugins branch November 5, 2017 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants