Skip to content

perf(form-checkboxes): convert templates to render functions #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 13, 2017

Conversation

tmorehouse
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 11, 2017

Codecov Report

Merging #1338 into dev will decrease coverage by 0.06%.
The diff coverage is 49.09%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev   #1338      +/-   ##
=========================================
- Coverage   41.56%   41.5%   -0.07%     
=========================================
  Files         130     130              
  Lines        2656    2653       -3     
  Branches      828     824       -4     
=========================================
- Hits         1104    1101       -3     
+ Misses       1207    1197      -10     
- Partials      345     355      +10
Impacted Files Coverage Δ
src/mixins/form-radio-check.js 61.53% <100%> (+2.16%) ⬆️
src/components/form-checkbox/form-checkbox.js 39.02% <39.02%> (ø)
...rc/components/form-checkbox/form-checkbox-group.js 75% <75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70ea87e...74d1cf1. Read the comment docs.

@tmorehouse tmorehouse merged commit 49bc50b into dev Nov 13, 2017
@tmorehouse tmorehouse deleted the renderfn/form-checkbox branch November 13, 2017 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants