feat(table): add toggleDetails method to scoped item slots #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1404 +/- ##
==========================================
- Coverage 42.46% 42.45% -0.01%
==========================================
Files 130 130
Lines 2918 2923 +5
Branches 903 906 +3
==========================================
+ Hits 1239 1241 +2
- Misses 1278 1281 +3
Partials 401 401
Continue to review full report at Codecov.
|
tmorehouse
changed the title
pi0
pushed a commit
that referenced
this pull request
Nov 29, 2017
* feat(table): add toggelDetails method to scoped item slots * add toggleDetails to details scoped var * documentation update * Update README.md * Update README.md * Update README.md * Use idMixin and add aria-describedby for details * ESlint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a function reference to the row's field scope variable for toggling the display of the row details scoped slot. Uses the
$setmethod to ensure reactivity, and negate the need to pre-define_showDetailsproperty in the item record for reactivity.