Skip to content

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Jun 11, 2019

Describe the PR

In some instances the ignoreBackdropClick flag was not being cleared

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@tmorehouse tmorehouse changed the title fix(modal): adjustment to cickout handling and ignoreBackdropClick flag fix(modal): ensure ignoreBackdropClick flag is cleared in clickOutHandler Jun 11, 2019
@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #3488 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3488   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files         224      224           
  Lines        4300     4300           
  Branches     1226     1226           
=======================================
  Hits         4268     4268           
  Misses         26       26           
  Partials        6        6
Impacted Files Coverage Δ
src/components/modal/modal.js 99.53% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4ac081...0f5cc8a. Read the comment docs.

@tmorehouse tmorehouse requested a review from jacobmllr95 June 11, 2019 14:30
@tmorehouse tmorehouse marked this pull request as ready for review June 11, 2019 14:30
@tmorehouse tmorehouse merged commit afb4680 into dev Jun 11, 2019
@tmorehouse tmorehouse deleted the tmorehouse/modal branch June 11, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants