Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Ellipsoidal SRTM dataset #42

Merged
merged 3 commits into from
Nov 17, 2020
Merged

Added Ellipsoidal SRTM dataset #42

merged 3 commits into from
Nov 17, 2020

Conversation

kxtells
Copy link
Contributor

@kxtells kxtells commented Nov 17, 2020 •
edited
Loading

This PR adds new product SRTM1_ELLIP with the opentopography datasource containing height from ellipsoid which is useful for some kind of analysis.

Also added a test for the new function srtm_ellip_tiles_names, ran with tox and python3.7 with no errors in sight. But did not test with the rest of interpreters:

 summary 
  docs: commands succeeded
  py27: commands succeeded
ERROR:  py34: InterpreterNotFound: python3.4
ERROR:  py35: InterpreterNotFound: python3.5
ERROR:  py36: InterpreterNotFound: python3.6
ERROR:  pypy: InterpreterNotFound: pypy
  qc: commands succeeded

Thanks for the elevation library, it has been very useful to me in the past so I'm more than happy to contribute :-D

@alexamici alexamici merged commit ac37f67 into bopen:master Nov 17, 2020
@alexamici
Copy link
Member

Thanks a lot!

@kxtells
Copy link
Contributor Author

kxtells commented Nov 18, 2020

Thank you for your time :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avalentino avalentino avalentino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kxtells @alexamici @avalentino