Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package rmview #11

Merged
merged 6 commits into from
Sep 11, 2020
Merged

Package rmview #11

merged 6 commits into from
Sep 11, 2020

Conversation

ChrisPattison
Copy link

This packages rmview. An example installation & usage with a remarkable already setup is below.

Ideally there would be a command included in the package to install the binaries on the remarkable so that an install&run flow would be pip install rmview rmview_rm_install rmview

Screen Shot 2020-08-06 at 6 34 33 PM

@ChrisPattison
Copy link
Author

As an aside, it wouldn't be a bad idea to search ~./rmview for a configure file

@bordaigorl
Copy link
Owner

Thank you for this!
I will have a look and merge soon.
I want to improve the readme and the configuration system a little anyway.
The config should be probably first searched in the standard paths of the host OS...

bordaigorl
bordaigorl previously approved these changes Sep 11, 2020
Copy link
Owner

@bordaigorl bordaigorl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried running pip install ., it runs fine but then I get an exception on run:

from . import resources 
ImportError: attempted relative import with no known parent package

@bordaigorl bordaigorl dismissed their stale review September 11, 2020 01:12

error during testing

@bordaigorl
Copy link
Owner

My bad, made a mistake. Works fine, ready to merge

@bordaigorl bordaigorl merged commit f64c65e into bordaigorl:vnc Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants