-
-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use crc32 from libdeflate, remove bundled crc32 code #6387
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6387 +/- ##
=======================================
Coverage 83.15% 83.15%
=======================================
Files 39 39
Lines 10457 10457
Branches 2057 2057
=======================================
Hits 8696 8696
Misses 1254 1254
Partials 507 507 Continue to review full report at Codecov.
|
Local test on MBA, macOS 12 (M1 cpu):
On github CI, macOS (x64):
On github CI, Linux (x64):
|
OK, so guess this means:
And we'll remove our bundled crc32 code, looks like the stuff in |
8e5f3c7
to
c774ac9
Compare
we use zlib.crc32 (macOS) or libdeflate_crc32 (Linux and all others) now.
No description provided.