Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prune prunes too much? #38

Closed
ThomasWaldmann opened this issue Nov 21, 2018 · 1 comment
Closed

prune prunes too much? #38

ThomasWaldmann opened this issue Nov 21, 2018 · 1 comment

Comments

@ThomasWaldmann
Copy link
Collaborator

I didn't practically try it, but the code looks like prune is not used with --prefix option.
In this case, prune specification applies to all archives in the repository.

If one backs up multiple clients (or in general: multiple data sets) into one rep, it will likely delete archives that should not get deleted.

So, if archive names are like hostname-datasetname-timestamp, we should use --prefix hostname-datasetname- and the prune options should be set per hostname-datasetname combination.

@m3nu
Copy link
Contributor

m3nu commented Nov 22, 2018

I didn't consider this use case. To avoid unexpected prunes, I added platform.node() as prefix. The create subcommand uses it as prefix as well.

@m3nu m3nu closed this as completed in 1894558 Nov 22, 2018
m3nu added a commit that referenced this issue Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants