Translation-related improvements and German translation #146
Conversation
m3nu
force-pushed
the
i18n-cleanup
branch
3 times, most recently
from
41f40eb
to
14076dd
Compare
.gitignore
Outdated
| @@ -6,6 +6,7 @@ docs/ | |||
| *.autosave | |||
| bin/macosx64/Sparkle.framework | |||
| bin/macosx64/borg | |||
There was a problem hiding this comment.
oops. i recently killed that subdir because the vorta.spec works more easily in bin/ (not bin/macosx64).
is it required by sparkle?
There was a problem hiding this comment.
Not required. I just keep it there. This entry is redundant anyways due to the bin/* below.
src/vorta/i18n/__init__.py
Outdated
| @@ -13,7 +13,7 @@ def init_translations(app): | |||
| global application, translator, locale # if we don't keep a reference on these, it stops working. pyqt bug? | |||
| application = app | |||
| translator = QTranslator() | |||
| locale = QLocale() | |||
| locale = QLocale('de') | |||
There was a problem hiding this comment.
used for debugging and forget to remove again?
There was a problem hiding this comment.
i used this to debug:
LANG=de_DE vorta --foreground
There was a problem hiding this comment.
Yepp. Will use the env-var from now.
|
Left to do:
|
.gitignore
Outdated
| @@ -4,8 +4,7 @@ build/ | |||
| dist/ | |||
| docs/ | |||
| *.autosave | |||
| bin/macosx64/Sparkle.framework | |||
| bin/macosx64/borg | |||
| bin/* | |||
There was a problem hiding this comment.
assuming that the dist/ and docs/ work, no need for the *?
There was a problem hiding this comment.
is docs/ something you are still working on or why is it here?
There was a problem hiding this comment.
That's true. And they seem to work. 🎉
|
/me would push "review EN strings" to next PR. |
No description provided.