improve tray menu #153
improve tray menu #153
Conversation
|
Additional idea:
|
|
Here is how Nextcloud does it:
Keeping "Settings" is probably a good idea. Linking "Help" could make sense. There is already a tutorial. We also have the status display and "Quit" The "Vorta for BorgBackup" item should open something useful if it's there. Borg website? |
|
Here another one from "Coconut Battery"
|
|
This makes it more similar to the other apps. Disabling the title looks alright. Setting the font bold didn't have an effect on macOS. Made it a bit smaller actually.
|
|
Hmm, I don't have any apps which show a title in the context menu, and in fact, all those examples above are actions, not titles. So I'm not sure this is ok. "Open CoconutBattery" does something as well as "Open Nextcloud in browser". Having an action that does nothing is... unexpected. Maybe we can assume that the main Vorta window is not just for settings anymore and it's the Vorta application (which can be used to interact with borg backups as in mounting/unmounting/extracting archives), so the "Settings..." action can be moved up to the first position and renamed to "Open Vorta for BorgBackup..." |
|
I think the main purpose here is to add some Borg branding, which is OK and important. Maybe the window title is a better place than the context menu? Like so:
Restructuring the context menu a bit, like above is still a good idea too. |
|
As I said in the ticket, the intention was to make it clear what this tray item is (and also have it look a bit less ugly than something starting with a disabled (low contrast) item that is hard to read). If you just have "Settings" and "Next task" and some relatively generic icon, this is not really clear before you actually click on (now) "Settings". Actually, "Settings" is wrong. If you click on it, a window opens where you can do all sorts of stuff (backup, restore, list, check) and also configure some settings. So actually, what really happens is that the main application window opens (so saying "Open Vorta" would be already better IF the user knows what Vorta is). Not always is the person who currently looks through the tray items also the person who installed the stuff / who knows what is for what task. My intention by using "Vorta for Borg Backup" was to have some pun (sorry, if it did not get over) and also to give some context "ah, this is a backup tool!". Note: didn't put "Open" in front of the program name as it destroys the pun, makes the menu even wider and is not really needed, users are used to click on "X" to open X without explicitly having the text say "Open X". |
ThomasWaldmann
changed the title
|
About adding "Help" (show Vorta builtin or online help): yes, can be done later within a separate PR. OTOH, Vorta has some "more info" links already in the app window. "Vorta for Borg Backup" as app window title: can be done, but keep that last blank. :) |
- "Vorta for Borg Backup" open main window - pun intended. :) - removed "Settings"
ThomasWaldmann
force-pushed
the
tray-menu-title
branch
from
0513320
to
20c9bdf
Compare
|
Collapsed the changesets. Anything within the scope of my changes still to do? Shall I change the main window title to "Vorta for Borg Backup"? Can do that for consistency, but guess it is not really required. |
|
I'm good to go ahead. This kept me up at night, but I didn't come up with something smarter. I've renamed "Exit" to "Quit" (to match the other apps) and changed the window title.
|
to make flake8 happy.
|
Fixed the pep8 issue. In my part of the changes: @m3nu did not translate the window title. Just noticed that the pun does not work if this gets translated. So, we do not use tr() for this and always keep this in English? |
|
Added the translation and removed unused import.
"Vorta für Borg Datensicherung", "Vorta für BorgBackup"? What's your policy? Is it just "Borg" or "BorgBackup"? I use the latter more often. If "BorgBackup" is the name, it shouldn't be translated. I'm slightly in favor of using "BorgBackup" as application name here. Pun or not. This also clarifies the translation. |
|
What I meant is that "Vorta for Borg Backup" in English (AFAIK) also has the meaning that the Vorta are aiding/backing the Borg (or shall do so). That pun is gone if you translate only one word of it and if it is only the "for", because then the sentence is not read as English any more. |
I guessed so. But "for" has too many meanings. "X for president", "change X for Y", "get X for Y". And "Vorta" not being as well known as "borg" won't help either. |
|
We can just leave the decision to the translator using tr() at both places. |
|
Name of the software is Borg[ ]Backup, command and short form to refer to it is just borg. |
|
Noted. Will use "Borg Backup" from now on. |
pun intended. :)
fixes #149.