Improve password handling #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add password transparency, remove unneeded variable Removed variable from password validation Make confirm box have same properties as password box Remove prints and add comment Don't run password transparency in exisitng repo Remove unneded variable Seperate password errors from other errors Use password label, move pass length validation Undo QT 5 Designer changes Check for no encryption for pass validation Remove empty methods, use activated over currentIndexChanged Lint Update test Update tests again Revert "Lint" This reverts commit c17d0d8. Run password validation on click Fix bad variable name Update transparency on encryption change Click save before testing password label Add 'be' Set text rather than typing Make passwords greater than 8 in length Validate password while typing Update plaintext warning message Offer alternatives to plain text password storage Update plaintext warning message Clarify that Linux has secret service api and macos has keychain access Clarify where the passwords will be stored Lint Run password transparency in existing repo window, reduce wordiness Old secret service API message was too long and confusing Lint Grammar Seperate password validation function For samuel-w/KeyManagement Lint lint again Fix so that label updates on default keyring, break plaintext warning onto 2 lines Cleanup message setting, add KWallet messages Lint Lint Move password validation to utils
I tried to get it working, if someone else wants to try feel free This reverts commit 58ed4ef.
Fixes password detection failure when starting without keyring program open, opening keyring program and then running backup. Vorta goes directly to DBKeyring, instead of going down the chain of programs.
Codecov Report
@@ Coverage Diff @@
## master #550 +/- ##
==========================================
- Coverage 73.52% 73.28% -0.25%
==========================================
Files 53 53
Lines 3509 3578 +69
==========================================
+ Hits 2580 2622 +42
- Misses 929 956 +27
Continue to review full report at Codecov.
|
|
What's the status of this PR? |
m3nu
requested changes
Nov 29, 2020
src/vorta/utils.py
Outdated
| if encryption != 'none': | ||
| keyringClass = VortaKeyring.get_keyring().__class__.__name__ | ||
| messages = { | ||
| 'VortaDBKeyring': trans_late('utils', 'plaintext on disk.\nVorta supports {storage} for password storage'.format(storage=platform.get(sys.platform))), # noqa |
There was a problem hiding this comment.
How about adding those messages to the individual Keyring classes to have it all in one?
src/vorta/utils.py
Outdated
| 'VortaKWallet5Keyring': trans_late('utils', 'KWallet 5'), | ||
| 'VortaKWallet4Keyring': trans_late('utils', 'KWallet 4') | ||
| } | ||
| # Just in case some other keyring support is added |
|
I added some comments. Can be merged with minor changed, I think. Good PR really. Extra points for adding tests. 😄 |
|
I think the keyring messages cannot be changed, see my comments earlier. #550 (comment) |
|
Actually, instead of an individual message for each keyring, should it just be one message for secure keyring and one message for insecure keyring, since most people use only one password manager at a time ? |
m3nu
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed branch, old PR #518
d7bb562 relates to #540, but should work without it
How should I format my code for easier translation later?
Fixes #385