-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if keyring is unlocked before setting password #607
Conversation
Volunteer here. 👋 |
It's only should pop up if you dismiss the keyring unlock prompt. The goal is to prevent set password from running with a locked keyring as in that case it would not write the password and could crash things. |
Codecov Report
@@ Coverage Diff @@
## master #607 +/- ##
==========================================
- Coverage 74.48% 74.03% -0.46%
==========================================
Files 53 53
Lines 3422 3428 +6
==========================================
- Hits 2549 2538 -11
- Misses 873 890 +17
Continue to review full report at Codecov.
|
Is this good to go? |
This overlaps with #550. So let's merge that first and then rebase to avoid any conflicts. |
After that I'll test on macOS. Though most changes are for Linux. Locked keychains are possible, but very unusual for the main login keychain in macOS. |
I need someone to test the macOS keyring. Should display
Please unlock your password manager.
if locked, nothing if unlocked when adding a repository. I have no idea whether it will work or not since I don't have a mac to test it on.Could still break since lock check happens a few seconds before adding a repository, but I think this covers most cases. The only way to fix it would be to set the password and then delete it if the action failed which is a bit clunky and could result in data loss. Just don't lock the keyring in the 10 seconds it takes to add a repo.
Fixes #606