Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove failing SSH key check #887

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Conversation

m3nu
Copy link
Contributor

@m3nu m3nu commented Feb 23, 2021

Fixes #886

@codecov-io
Copy link

codecov-io commented Feb 23, 2021

Codecov Report

Merging #887 (7ce4ec2) into master (3c0dd72) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #887      +/-   ##
==========================================
+ Coverage   70.35%   70.38%   +0.02%     
==========================================
  Files          56       56              
  Lines        3791     3788       -3     
==========================================
- Hits         2667     2666       -1     
+ Misses       1124     1122       -2     
Impacted Files Coverage Δ
src/vorta/borg/borg_thread.py 76.79% <ø> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c0dd72...7ce4ec2. Read the comment docs.

@m3nu
Copy link
Contributor Author

m3nu commented Feb 23, 2021

Reverting a few lines from your PR, @samuel-w . Have to admit that the code is confusing and the bug rare. Sorry for that. :-(

@m3nu m3nu merged commit 8da81e7 into borgbase:master Feb 23, 2021
@m3nu m3nu deleted the issue/886/repo-attr-error branch February 23, 2021 13:38
@samuel-w
Copy link
Contributor

Actually it could have been solved by modifiying the fakerepo. No big deal, lets fix it when someone files a bug report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled Exception on Create Remote Repository Failure [macOS Mojave]
3 participants