Refuse to add inaccessible folders, warn on inaccessible files during backup #951
Conversation
src/vorta/borg/create.py
Outdated
| if result['returncode'] == 1: | ||
| self.app.backup_progress_event.emit(self.tr('Backup finished. Some files were not accessible.')) |
There was a problem hiding this comment.
I'm not sure that this is correct, because doesn't borg use returncode=1 as a catch-all for a variety of errors?
There was a problem hiding this comment.
You're right. Could also be "Backup finished with warnings. See logs for details."
Upside is it's more "correct". Downside is that the large majority of warnings will be access errors. Can't think of other warnings I've seen. That fact is now hidden in the logs.
There was a problem hiding this comment.
I've added a separate issue #952 to nag Mac users about Full Disk access. This should make such errors very rare and we can use the vague sentence. "Backup finished with warnings. See logs for details."
OK?
There was a problem hiding this comment.
I've now merged the feature to nag Mac users about proper permissions. Mostly due to a overwhelming response on Twitter: https://twitter.com/borg_base/status/1383302657045979144
With this, access errors would be fairly rare everywhere and the more vague sentence should be fine.
We now refuse to add unreadable folders and .
warn about access errors during backup
Fixes #916 (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=987074)