Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake Warning Fixes #1115

Merged
merged 2 commits into from Feb 21, 2022
Merged

CMake Warning Fixes #1115

merged 2 commits into from Feb 21, 2022

Conversation

varunagrawal
Copy link
Collaborator

Kept getting warnings during the CMake step which finally got me to crack and fix them.

@varunagrawal varunagrawal added cmake Related to CMake and build system quick-review Quick and easy PR to review labels Feb 21, 2022
@varunagrawal varunagrawal self-assigned this Feb 21, 2022
dellaert
dellaert approved these changes Feb 21, 2022
View reviewed changes
Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge at will

@varunagrawal varunagrawal merged commit d5a3a22 into develop Feb 21, 2022
@varunagrawal varunagrawal deleted the cmake-fixes branch February 21, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dellaert dellaert dellaert approved these changes

@gchenfc gchenfc Awaiting requested review from gchenfc

Assignees

@varunagrawal varunagrawal

Labels
cmake Related to CMake and build system quick-review Quick and easy PR to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@varunagrawal @dellaert