General check for null pointer in saveGraph #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varunagrawal
commented
Aug 31, 2020
| if(formatting.connectKeysToFactor && factor) { | ||
| for(Key key: *factor) { | ||
| stm << " var" << key << "--" << "factor" << i << ";\n"; | ||
| if (formatting.connectKeysToFactor && factor) { |
There was a problem hiding this comment.
This is just formatting.
varunagrawal
commented
Aug 31, 2020
| } | ||
| } | ||
| } | ||
| } | ||
| else { | ||
| if(factor) { |
There was a problem hiding this comment.
I removed this check since I added a generic check at the beginning.
varunagrawal
commented
Aug 31, 2020
| if(pos != formatting.factorPositions.end()) | ||
| stm << ", pos=\"" << formatting.scale*(pos->second.x() - minX) << "," | ||
| << formatting.scale*(pos->second.y() - minY) << "!\""; | ||
| map<size_t, Point2>::const_iterator pos = |
There was a problem hiding this comment.
Formatting changes.
varunagrawal
commented
Aug 31, 2020
| const KeyVector& keys = factor->keys(); | ||
| if (formatting.binaryEdges && keys.size()==2) { | ||
| stm << " var" << keys[0] << "--" << "var" << keys[1] << ";\n"; | ||
| if (formatting.binaryEdges && keys.size() == 2) { |
There was a problem hiding this comment.
Formatting changes
varunagrawal
commented
Aug 31, 2020
| if (!factor) { | ||
| continue; | ||
| } | ||
|
|
There was a problem hiding this comment.
This part is the main fix.
|
Thanks for fixing that, and sorry for not doing it myself. I was on holidays the last two weeks. |
|
Sure! I hope you had a nice holiday! |
|
Sure thing! Thanks for bringing up this issue and hope you had a nice holiday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #467