Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid target collision if gtsam used as submodule #691

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

jlblancoc
Copy link
Member

CMake ends with an error if gtsam is used as a git submodule in another project also having an uninstall() target.

This PR simply defines another target and makes the top-level one to depend on it, or fallback to the usual way if no other top-level uninstall exists.

@jlblancoc jlblancoc added the easy-fix Quick and easy to fix label Feb 28, 2021
Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varunagrawal varunagrawal merged commit 48232a3 into develop Mar 8, 2021
@varunagrawal varunagrawal deleted the fix-uninstall-target-exists branch March 8, 2021 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy-fix Quick and easy to fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants