Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section about Boost version requirement #857

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Conversation

varunagrawal
Copy link
Collaborator

As per the discussion in #850.

@varunagrawal varunagrawal added the docs Update to docs or README without code changes label Aug 23, 2021
@varunagrawal varunagrawal self-assigned this Aug 23, 2021
@varunagrawal varunagrawal added the quick-review Quick and easy PR to review label Aug 23, 2021
@dellaert
Copy link
Member

What about allowing 1.58 on 16.04 and printing a warning via cmake?

@varunagrawal
Copy link
Collaborator Author

Those kind of edge cases get messy especially since Ubuntu 16 is almost at the end of it's life term.

@dellaert
Copy link
Member

Those kind of edge cases get messy especially since Ubuntu 16 is almost at the end of it's life term.

This is what we had discussed, however. If you disagreed, why not mention it in the other thread?? End of life or not, many robots are indeed still at 16.04.

@varunagrawal
Copy link
Collaborator Author

varunagrawal commented Aug 23, 2021

CMake doesn't provide a way to get the underlying OS type and version aka Ubuntu 16.04. We would have to hack something up and it doesn't seem to be worth the effort.

My opinion is that for 16.04, installing Boost>1.65 via a 3rd party PPA such as mhier is a lot cleaner and something that end users can easily accomplish. It's literally 2 extra lines in their setup scripts.

@dellaert
Copy link
Member

Sounds good. Maybe add that info to the readme.

@varunagrawal
Copy link
Collaborator Author

Already did. I added a line about using alternative channels if the main package manager doesn't have support for the specified version.

@dellaert dellaert merged commit 6f9561e into develop Sep 7, 2021
@dellaert dellaert deleted the doc/boost-version branch September 7, 2021 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Update to docs or README without code changes quick-review Quick and easy PR to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants