JS: notification stub in sources #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinTail
added
documentation
|
Perhaps this should be marked as breaking. |
RobinTail
force-pushed
the
issue-115-stub
branch
from
7cf5231
to
7babfff
Compare
RobinTail
force-pushed
the
issue-115-stub
branch
from
7babfff
to
2d426e6
Compare
RobinTail
force-pushed
the
issue-115-stub
branch
from
b5b7810
to
630d03e
Compare
|
✅ QA passed Assets for changelog
|
Merged
RobinTail
added a commit
that referenced
this pull request
Jul 30, 2023
* Distributable ZIP-package (#129) * Removing redundant env var in CI. * Add sample releasing steps until the artifact upload. * Add missing dependency installation step. * Including changelog into the manifest. * Add integration test. * Removing JS file from the repo. * Removing the changes checking step from UI CI. * Add miniver installation step. * Add versioning step. * Installing miniver using GitHub Codespace. * Ignoring some files. * Using module name for importing version. * Add EOL. * Adding the miniver lines to setup.py. * Add Wheels installation step. * CI: excluding _version.py from coverage report. * Changing the trigger for Release workflow. * Trying checking with depth 0. * Only trigger on published type of release. * Patching miniver for using non-annotated tags. * Add the asset attachment job. * Using specific version of get-release action. * Changing the package download link for pip. * EOL for .gitattributes * minor, empty line in setup.py * Fix padding in release workflow. * Readme: changing the latest ditribution link. * Revert "Trying checking with depth 0." This reverts commit 1f4a92c. * Extracting versions into env, testing installation against variety. * Fix: add wheel installation step to integration test. * Minor: title. * Fix: build job name. * Ref: organizing the steps: UI first, Python next. * Changelog: the future 2.3.0. * JS: notification stub in sources (#132) * Making a stub for installations from sources. * Minor: grammar. * Ref: moving show() to the end. Using cancel button of the dialog instead. * Ref: shorter title. * Release workflow: stub removal explicit step. * Minior: comment. * Removing color - looks too agressive. * Fix: dialog notice font adjustments. * Changelog: the future 3.0.0. * Minor: text. * Changelog: moving breaking changes to the top. * Minor: text. * Ref: keeping off-on near. * Changelog: minor fixes and illustration. * FIX: wrong latest release asset URL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #115
Continuation of #129 — QA revealed a need for a stub
Switching to ZIP-package distribution requires user to update the plugin TWICE.
After the first update there will be no control buttons in navbar which I consider a disruption of service, requiring a user's action to fix.
In order to minimise the confusion I'm making a stub showing a warning icon for attracting user's attention on the needed action, and a dialog explaining what to do.