Fix broken non-ray button interactions, fix Daydream compat clicks #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using preventDefault on touch events prevented other onscreen interactive elements such as the "Enter VR" button from working. Since using preventDefault on touch events is discouraged anyway, change the logic to ignore duplicate events without suppressing them. See also https://developers.google.com/web/updates/2017/01/scrolling-intervention Also ignore the Cardboard-compatible click events generated by the Daydream controller while presenting to avoid duplicate event handling.
This was referenced Mar 31, 2017
|
@borismus, I didn't include the build/ output changes in my patch to avoid cluttering it, let me know if you want me to include those for easier merging. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using preventDefault on touch events prevented other onscreen
interactive elements such as the "Enter VR" button from working.
Since using preventDefault on touch events is discouraged anyway,
change the logic to ignore duplicate events without suppressing
them.
See also https://developers.google.com/web/updates/2017/01/scrolling-intervention
Also ignore the Cardboard-compatible click events generated
by the Daydream controller while presenting to avoid duplicate
event handling.