-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update clojure-ts-mode support #27
Conversation
I see why the CI is failing, but it seems to me it might be better to just depend on a explicit version of |
Also - might be good to look into abstracting away the test code duplication for the different major modes. |
There are 2 issues here.
|
The downside to using a explicit version of seq.el is that every downstream package(depending on flycheck) needs to keep track of what version of seq flycheck is depending on and update regularly whenever flycheck updates the version upstream. |
And also need to install (from source?) the clojure treesitter gramma, right? I think it is already more convenient but haven't tried/looked into how this works now. |
Luckily its already handled by I think we only need to make sure that the clojure-ts-mode tests are not run when emacs-version < 29.1. |
Thanks! |
Thanks @borkdude! I was about to make a few more changes to this PR (like moving ts tests to a new file and other minor stuff). Will raise a separate PR later as it is not critical. |
This is a follow up PR to #26.
clojure-ts-mode
.