Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failure with GHC 9.2.1 #19

Closed
sjakobi opened this issue Nov 11, 2021 · 3 comments
Closed

Build failure with GHC 9.2.1 #19

sjakobi opened this issue Nov 11, 2021 · 3 comments

Comments

@sjakobi
Copy link

sjakobi commented Nov 11, 2021 

Data/BloomFilter/Util.hs:43:38: error:
    • Couldn't match expected type ‘Word32#’ with actual type ‘Word#’
    • In the first argument of ‘W32#’, namely
        ‘(x# `uncheckedShiftL#` i#)’
      In the expression: W32# (x# `uncheckedShiftL#` i#)
      In an equation for ‘shiftL’:
          shiftL (W32# x#) (I# i#) = W32# (x# `uncheckedShiftL#` i#)
   |
43 |     shiftL (W32# x#) (I# i#) = W32# (x# `uncheckedShiftL#` i#)
   |                                      ^^^^^^^^^^^^^^^^^^^^^^^^

Data/BloomFilter/Util.hs:46:38: error:
    • Couldn't match expected type ‘Word32#’ with actual type ‘Word#’
    • In the first argument of ‘W32#’, namely
        ‘(x# `uncheckedShiftRL#` i#)’
      In the expression: W32# (x# `uncheckedShiftRL#` i#)
      In an equation for ‘shiftR’:
          shiftR (W32# x#) (I# i#) = W32# (x# `uncheckedShiftRL#` i#)
   |
46 |     shiftR (W32# x#) (I# i#) = W32# (x# `uncheckedShiftRL#` i#)
   |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^
cabal: Failed to build bloomfilter-2.0.1.0.
@sjakobi
Copy link
Author

sjakobi commented Nov 11, 2021

As a Hackage trustee, I have created a Hackage revision to prevent users from running into this build error: https://hackage.haskell.org/package/bloomfilter-2.0.1.0/revisions/

sjakobi added a commit to sjakobi/bloomfilter that referenced this issue Nov 12, 2021
@sjakobi
Fix build with GHC 9.2
795b70a 
The `FastShift.shift{L,R}` methods are replaced with `unsafeShift{L,R}`
introduced in base-4.5.

Fixes bos#19.
@sjakobi sjakobi mentioned this issue Nov 12, 2021
Closed
sjakobi added a commit to sjakobi/bloomfilter that referenced this issue Nov 13, 2021
@sjakobi
Fix build with GHC 9.2
fb79b39 
The `FastShift.shift{L,R}` methods are replaced with `unsafeShift{L,R}`
introduced in base-4.5.

Fixes bos#19.
@sjakobi
Copy link
Author

sjakobi commented May 2, 2022

As a Hackage trustee, I have created a Hackage revision to prevent users from running into this build error: https://hackage.haskell.org/package/bloomfilter-2.0.1.0/revisions/

Actually I had made a mistake in this revision. I had tightened the bound on base only for the testsuite.

I have now created a second revision that tightens the base bound for the library.

@sternenseemann sternenseemann mentioned this issue Dec 8, 2022
Merged
@joeyh
Copy link
Collaborator

joeyh commented Aug 4, 2023

fixed in 2.0.1.1

@joeyh joeyh closed this as completed Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix build with GHC 9.2 sjakobi/bloomfilter
2 participants
@joeyh @sjakobi