Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with GHC 9.2 #20

Closed
wants to merge 2 commits into from
Closed

Fix build with GHC 9.2 #20

wants to merge 2 commits into from

Conversation

sjakobi
Copy link

@sjakobi sjakobi commented Nov 12, 2021

…and setup CI on GitHub Actions.

Fixes #19.

@sjakobi
Copy link
Author

sjakobi commented Nov 12, 2021

I've checked that CI works in sjakobi#1.

The `FastShift.shift{L,R}` methods are replaced with `unsafeShift{L,R}`
introduced in base-4.5.

Fixes bos#19.
@blackgnezdo
Copy link

Any chance this can be merged and then released? This prevents aws package and then transitively git-annex from building with ghc-9.2.

@sjakobi
Copy link
Author

sjakobi commented Mar 27, 2022

Since the sole maintainer, @bos, hasn't been active on GitHub for a while, it would probably be best if someone would volunteer to take over and maintain this package.

FWIW, I'm not currently interested in serving as a maintainer for this package.

@arrowd
Copy link

arrowd commented Jul 6, 2022

@bos Can you, please, take a look at this PR?

@Bodigrim
Copy link

@arrowd someone has to step up and ask to take over. My understanding is that @bos is not maintaining his Haskell packages any longer.

slotThe added a commit to slotThe/void-packages that referenced this pull request Dec 30, 2022
Patch bloomfilter to fix the build for GHC 9.2.5.

Related: bos/bloomfilter#20
@joeyh
Copy link
Collaborator

joeyh commented Apr 12, 2023

I suppose git-annex is one of the major users of bloomfilter now. As its maintainer I'm willing to do some maintenance of bloomfilter if necessary. But I don't have any deep expertise in bloom filters and fear I would not be able to do more than basic keep it working maintenance..

@Bodigrim
Copy link

I think even a very basic maintenance is better than none, so I'd like to encourage you to take over the packge.

@joeyh
Copy link
Collaborator

joeyh commented Apr 13, 2023

@bos if it's ok with you, I am considering transferring bloomfilter to https://github.com/haskell-pkg-janitors and maintaining it there (also assuming it's ok with them)

@Bodigrim
Copy link

I'd suggest sending an email to @bos, his GitHub account seems abandoned.

@joeyh
Copy link
Collaborator

joeyh commented Aug 4, 2023

@bos has agreed to pass maintenace to me.

https://github.com/haskell-pkg-janitors/bloomfilter is the new repository. I've applied this fix there and will release as soon as we sort out hackage permissions.

@joeyh
Copy link
Collaborator

joeyh commented Aug 4, 2023

released in 2.0.1.1

@joeyh joeyh closed this Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure with GHC 9.2.1
5 participants