Adapt FastShift instances for Word32 to ghc-9.4.x. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that #20 fixes this in a better way. That approach will work with older versions of ghc as well. FastShift was originally added to work around a ghc performance problem of a shift involving a test and branch. It used uncheckedShiftL# to avoid that overhead. Then unsafeShiftL was added to ghc, which does exactly the same thing for Word32. |
|
Closing this since it was fixed in the other way in 2.0.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ghc-9.4.x changed the type of Word32. This trivial patch fixes the build with the latest version.