Reward a predefined address a certain amount #1

omerfirmak · 2022-05-16T14:17:46Z

This is the point that makes most sense to me for rewarding the commons budget, per block. Will test to see if this works in practice.

hewison-chris · 2022-05-16T21:06:46Z

Nice, this looks like it could work.
Can you open PR to agora branch though. I should have mentioned before we will use it for our changes to start with.

linked0 · 2022-05-17T01:04:13Z

Good, I will try to do unit tests with it. @hewison-chris, Don't we have to create a new branch on every PR with a forked repository?

linked0 · 2022-05-17T01:23:03Z

Good start, but I think it could be better to remove the TODOs in this PR's code after adding the related commits.

hewison-chris · 2022-05-17T01:25:45Z

Good start, but I think it could be better to remove the TODOs in this PR's code after adding the related commits.

~~I think that was the whole point of the TODO comments.~~
I think I just realized what you meant. Let's implement the TODOs before merging. However it can still be tested as is.

core/state_processor.go

omerfirmak · 2022-05-17T12:18:29Z

a miner node strangely bypasses this path, will try to move it elsewhere.

MichaelKim20 · 2022-05-18T01:29:05Z

That's a good try.
Below is the code to pay rewards in POW.
https://github.com/zeroone-boa/go-ethereum/blob/agora/consensus/ethash/consensus.go#L595
https://github.com/zeroone-boa/go-ethereum/blob/agora/consensus/ethash/consensus.go#L645-L668

Apply it to the POA code below
I think that'll do
https://github.com/zeroone-boa/go-ethereum/blob/agora/consensus/clique/clique.go#L564-L568

omerfirmak · 2022-05-18T05:06:59Z

Those functions will not be called after the merge, see the updated code. It works fine

omerfirmak · 2022-05-18T06:29:33Z

Tested to work fine, ready to review

omerfirmak · 2022-05-18T07:37:45Z

Renamed commonsBudget config to commonsBudgetContract to emphasize that commons budget is expected to be a contract, as per @hewison-chris's request

hewison-chris

LGTM

miner/worker.go

hewison-chris · 2022-05-18T07:40:09Z

Renamed commonsBudget config to commonsBudgetContract to emphasize that commons budget is expected to be a contract, as per @hewison-chris's request

Perhaps as it works for either just the comment update is ok.

MichaelKim20 · 2022-05-20T04:34:50Z

What is the rule that it is issued only for the first six years?

hewison-chris · 2022-05-20T04:49:29Z

What is the rule that it is issued only for the first six years?

The white paper specifies that it should only reward the Commons Budget with 50 coins per 5 secs until 1_800_000_000 coins are rewarded. This is not yet implemented in this PR.

MichaelKim20 · 2022-05-20T05:54:20Z

Let me test it

First, run the existing geth.
Deploy the Smart Contract of the Commons Budget.
Enter the address of the Smart Budget in the code of geth, build it, and run it.
Verify that it is issued to the address of Commons Budget.

core/bosagora/commonsbudget.go

MichaelKim20 · 2022-05-20T06:57:49Z

#1 (comment)
@omerfirmak Could you test it in the same way as above?
Because we can't change the value made by BizNet.
Therefore, in order to fork later, the source must be modified and distributed.
My test result didn't go well. I entered the address in the source, but it doesn't apply well.

MichaelKim20 · 2022-05-20T12:04:13Z

@omerfirmak I changed the value of header.Coinbase to the address of the common budget in POA and it works well.
Can you check it for me?

omerfirmak · 2022-05-20T13:21:46Z

@MichaelKim20 see the updated code, but dont change the source, just configure it using the genesis file.

example;

{
    "config": {
        "chainId": 2020,
        "homesteadBlock": 0,
        "eip150Block": 0,
        "eip155Block": 0,
        "eip158Block": 0,
        "byzantiumBlock": 0,
        "constantinopleBlock": 0,
        "petersburgBlock": 0,
        "istanbulBlock": 0,
        "berlinBlock": 0,
        "londonBlock": 0,
        "arrowglacierBlock": 0,
        "terminalTotalDifficulty": 20000000000000,
        "clique": {
          "period": 14,
          "epoch": 30000
        },
        "commonsBudget" : "0x087511AeF3B01d72C6c9f4F514560bc0577DF3bb",
        "commonsBudgetReward": 4,
        "lastCommonsBudgetRewardBlock": 50
    },
    "difficulty": "1",
    "gasLimit": "8000000",
    "extradata": "0x0000000000000000000000000000000000000000000000000000000000000000e79b1aeF1a4DD5E45F8D4B1CFABA71bedE94EF260000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
    "alloc": {
        "0xA87511AeF3B01d72C6c9f4F514560bc0577DF3bb" : { "balance": "542130130195846300000000000" },
        "0x82fFb1bB229552D020C88b9eE8D5e4042E6Cbd42" : { "balance": "100000000000000000000000000" },
        "0xC64edC529C17D593f5339E02C9055312cE0718B7" : { "balance": "100000000000000000000000000" }
      }
}

MichaelKim20 · 2022-05-20T23:49:52Z

I confirmed that the common budget is issued through the command below.
eth.getBalance("0x087511AeF3B01d72C6c9f4F514560bc0577DF3bb")

However, it is not visible in 'BlockScout'.

It would be better to create a different issue, right?

MichaelKim20 · 2022-05-20T23:53:41Z

When we open BizNet, the contents of genesis.json do not include items related to Commons Budget.
How can we add this params when we launch Agora's main net?

If you can make another issue and deal with it, This PR is great

omerfirmak · 2022-05-21T06:42:44Z

I confirmed that the common budget is issued through the command below. eth.getBalance("0x087511AeF3B01d72C6c9f4F514560bc0577DF3bb")

However, it is not visible in 'BlockScout'.

It would be better to create a different issue, right?

That should be a problem on the explorer side. I bet if you send a TX to that address it will start to show just fine.

omerfirmak · 2022-05-21T06:43:23Z

How can we add this params when we launch Agora's main net?

We can make it a scheduled hard fork in BizNet

MichaelKim20 · 2022-05-22T11:25:10Z

How can we add this params when we launch Agora's main net?

We can make it a scheduled hard fork in BizNet

Then I'd like to add one more parameter. I think it would be good to add the number of the block where the commons budget starts to be issued.
ex) startCommonsBudgetRewardBlock

MichaelKim20

LGTM

MichaelKim20 · 2022-05-23T02:03:10Z

@omerfirmak I create a new issue and merge it.
#2

omerfirmak · 2022-05-25T11:05:20Z

I confirmed that the common budget is issued through the command below. eth.getBalance("0x087511AeF3B01d72C6c9f4F514560bc0577DF3bb")

However, it is not visible in 'BlockScout'.

It would be better to create a different issue, right?

This seem to be a limitation on the blockscout part, it only updates balances on new TXs.

mkykadir · 2022-06-08T12:31:40Z

I am testing this with local test-env but couldn't see the block rewards somehow

-- Tested with local build and singe node, it works; looking for why it didn't work in Docker net

hewison-chris · 2022-06-09T00:39:22Z

I am testing this with local test-env but couldn't see the block rewards somehow

I think this was also mentioned here #1 (comment)
It might be a problem in the Explorer. Can you check if eth.getBalance shows the expected value?

mkykadir · 2022-06-09T10:14:43Z

I am testing this with local test-env but couldn't see the block rewards somehow

I think this was also mentioned here #1 (comment) It might be a problem in the Explorer. Can you check if eth.getBalance shows the expected value?

Testing with getBalance, still returns 0 on all miners.
My bad, I was using geth without our changes to initialize our node folders from genesis

MichaelKim20 reviewed May 17, 2022

View reviewed changes

core/state_processor.go Outdated Show resolved Hide resolved

omerfirmak changed the base branch from master to agora May 18, 2022 06:29

hewison-chris approved these changes May 18, 2022

View reviewed changes

miner/worker.go Outdated Show resolved Hide resolved

hewison-chris mentioned this pull request May 20, 2022

Validator rewards following the Bosagora white paper bosagora/agora-cl#2

Closed

MichaelKim20 reviewed May 20, 2022

View reviewed changes

core/bosagora/commonsbudget.go Outdated Show resolved Hide resolved

Configurable CommonsBudget and reward amount

5fec40a

MichaelKim20 approved these changes May 22, 2022

View reviewed changes

MichaelKim20 mentioned this pull request May 23, 2022

Implement a hard fork for the Commons Budget setting #2

Closed

MichaelKim20 merged commit af70d58 into bosagora:agora May 23, 2022

MichaelKim20 mentioned this pull request May 23, 2022

The amount of issuance is not aggregated in the Commons budget. bosagora/boa-scan#1

Open

hewison-chris assigned omerfirmak May 23, 2022

omerfirmak mentioned this pull request May 23, 2022

Implement the ability to issue Commons Budgets as defined in the Bosagora White Paper bosagora/AgoraMainNet#6

Closed

MichaelKim20 unassigned omerfirmak Sep 26, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reward a predefined address a certain amount #1

Reward a predefined address a certain amount #1

omerfirmak commented May 16, 2022

hewison-chris commented May 16, 2022

linked0 commented May 17, 2022

linked0 commented May 17, 2022

hewison-chris commented May 17, 2022 •

edited

Loading

omerfirmak commented May 17, 2022

MichaelKim20 commented May 18, 2022

omerfirmak commented May 18, 2022

omerfirmak commented May 18, 2022 •

edited

Loading

omerfirmak commented May 18, 2022

hewison-chris left a comment

hewison-chris commented May 18, 2022

MichaelKim20 commented May 20, 2022

hewison-chris commented May 20, 2022

MichaelKim20 commented May 20, 2022

MichaelKim20 commented May 20, 2022

MichaelKim20 commented May 20, 2022

omerfirmak commented May 20, 2022

MichaelKim20 commented May 20, 2022 •

edited

Loading

MichaelKim20 commented May 20, 2022 •

edited

Loading

omerfirmak commented May 21, 2022

omerfirmak commented May 21, 2022 •

edited

Loading

MichaelKim20 commented May 22, 2022

MichaelKim20 left a comment

MichaelKim20 commented May 23, 2022

omerfirmak commented May 25, 2022

mkykadir commented Jun 8, 2022 •

edited

Loading

hewison-chris commented Jun 9, 2022

mkykadir commented Jun 9, 2022 •

edited

Loading

Reward a predefined address a certain amount #1

Reward a predefined address a certain amount #1

Conversation

omerfirmak commented May 16, 2022

hewison-chris commented May 16, 2022

linked0 commented May 17, 2022

linked0 commented May 17, 2022

hewison-chris commented May 17, 2022 • edited Loading

omerfirmak commented May 17, 2022

MichaelKim20 commented May 18, 2022

omerfirmak commented May 18, 2022

omerfirmak commented May 18, 2022 • edited Loading

omerfirmak commented May 18, 2022

hewison-chris left a comment

Choose a reason for hiding this comment

hewison-chris commented May 18, 2022

MichaelKim20 commented May 20, 2022

hewison-chris commented May 20, 2022

MichaelKim20 commented May 20, 2022

MichaelKim20 commented May 20, 2022

MichaelKim20 commented May 20, 2022

omerfirmak commented May 20, 2022

MichaelKim20 commented May 20, 2022 • edited Loading

MichaelKim20 commented May 20, 2022 • edited Loading

omerfirmak commented May 21, 2022

omerfirmak commented May 21, 2022 • edited Loading

MichaelKim20 commented May 22, 2022

MichaelKim20 left a comment

Choose a reason for hiding this comment

MichaelKim20 commented May 23, 2022

omerfirmak commented May 25, 2022

mkykadir commented Jun 8, 2022 • edited Loading

hewison-chris commented Jun 9, 2022

mkykadir commented Jun 9, 2022 • edited Loading

hewison-chris commented May 17, 2022 •

edited

Loading

omerfirmak commented May 18, 2022 •

edited

Loading

MichaelKim20 commented May 20, 2022 •

edited

Loading

MichaelKim20 commented May 20, 2022 •

edited

Loading

omerfirmak commented May 21, 2022 •

edited

Loading

mkykadir commented Jun 8, 2022 •

edited

Loading

mkykadir commented Jun 9, 2022 •

edited

Loading