Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network manager sends a transaction even if a node already has the transaction #210

Closed
AndrejMitrovic opened this issue Aug 20, 2019 · 0 comments · Fixed by #217
Closed

Network manager sends a transaction even if a node already has the transaction #210

AndrejMitrovic opened this issue Aug 20, 2019 · 0 comments · Fixed by #217
Assignees
@AndrejMitrovic

Comments

@AndrejMitrovic
Copy link
Contributor

The node implements a hasTransactionHash API, but the network manager gossips the transaction to a node even if that node already contains the transaction.

The node should instead query the target node's hasTransactionHash(), and only send the transaction if hasTransactionHash() returns false.
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue Aug 21, 2019
@AndrejMitrovic
Don't send transaction if a node already has it
e1939c0 
Use the 'hasTransactionHash()' API to query a node
before sending it a transaction which it may
already contain.

Fixes bosagora#210
@AndrejMitrovic AndrejMitrovic mentioned this issue Aug 21, 2019
Merged
@AndrejMitrovic AndrejMitrovic self-assigned this Aug 21, 2019
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue Aug 22, 2019
@AndrejMitrovic
Don't send transaction if a node already has it
8e98235 
Use the 'hasTransactionHash()' API to query a node
before sending it a transaction which it may
already contain.

Fixes bosagora#210
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue Aug 22, 2019
@AndrejMitrovic
Don't send transaction if a node already has it
104ca7f 
Use the 'hasTransactionHash()' API to query a node
before sending it a transaction which it may
already contain.

Fixes bosagora#210
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue Aug 23, 2019
@AndrejMitrovic
Don't send transaction if a node already has it
9d5999f 
Use the 'hasTransactionHash()' API to query a node
before sending it a transaction which it may
already contain.

Fixes bosagora#210
Geod24 pushed a commit that referenced this issue Aug 23, 2019
@AndrejMitrovic @Geod24
Don't send transaction if a node already has it
7f2194d 
Use the 'hasTransactionHash()' API to query a node
before sending it a transaction which it may
already contain.

Fixes #210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrejMitrovic AndrejMitrovic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't send a transaction if a node already has it AndrejMitrovic/agora
1 participant
@AndrejMitrovic