Refactor some Nominator & NetworkManager code #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrejMitrovic
added
the
type-refactoring
Codecov Report
@@ Coverage Diff @@
## v0.x.x #618 +/- ##
==========================================
+ Coverage 90.06% 90.07% +<.01%
==========================================
Files 62 62
Lines 4571 4564 -7
==========================================
- Hits 4117 4111 -6
+ Misses 454 453 -1
Continue to review full report at Codecov.
|
|
Really? That was not my intention, but I'm glad if it's true. 👀 |
maybe Intermittent http error began to be invisible. |
Geod24
approved these changes
Mar 5, 2020
AndrejMitrovic
force-pushed
the
get-quorum
branch
from
723219a
to
7e9fffa
Compare
Clients should not expect any status code when issuing calls to the receiveEnvelope() API. The node itself may care whether its internal SCP class considers the envelope valid or not, but it does not need to signal back to the client whether it accepted the envelope. This is because this API should be used in an asynchronous way. Aftera client floods a given SCPEnvelope to the network, it does not care about how that envelope is further processed by each node.
The transaction is propagated to the entire network, so the name of the function should reflect that.
The NetworkManager should be in charge of gossiping any transactions and SCPEnvelopes. This reduces complexity, and avoids delayed initialization of the set of peers in the Nominator class. Additionally, in the future this will enable easier gossiping to clients which connected to us first, see issue bosagora#606 for more info.
AndrejMitrovic
force-pushed
the
get-quorum
branch
from
7e9fffa
to
2105ebb
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of fixing #606
While implementing the feature, I've realized there are leaky abstractions here. In fact SCP only requires two networking functionalities:
The second part can be left to the NetworkManager, as it also deals with features such as node banning, receiving new network connections (to be done), etc.