Add missing definition of operator() for hashing support #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It makes it easier to see if there are any missing object files.
AndrejMitrovic
added
the
type-bug
Codecov Report
@@ Coverage Diff @@
## v0.x.x #659 +/- ##
==========================================
+ Coverage 90.18% 90.19% +<.01%
==========================================
Files 62 63 +1
Lines 4648 4649 +1
==========================================
+ Hits 4192 4193 +1
Misses 456 456
Continue to review full report at Codecov.
|
|
I guess you want to import the quorum intersection check in C++ ? |
Geod24
reviewed
Mar 13, 2020
| void | ||
| initialize() | ||
| { | ||
| crypto_shorthash_keygen(sKey); |
There was a problem hiding this comment.
This has to be called so you might want to stick a shared static this in the bindings
AndrejMitrovic
force-pushed
the
missing-hash
branch
from
7d20527
to
0395cf9
Compare
Yes. And it's a lot of code (2 Kloc or so) so I opted to bind to it rather than port it to D. Updated to add the initialization call. |
AndrejMitrovic
force-pushed
the
missing-hash
branch
from
0395cf9
to
123ef1c
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::hash is used for things like storing structs in std::set / std::map.
Required for the quorum intersection checker.