Correct the Github actions CI Test to return the error level correctly #731
Conversation
TrustHenry
added
the
type-bug
ci/run.bat
Outdated
| @@ -1,4 +1,8 @@ | |||
| call dub test --skip-registry=all --compiler=%DC% | |||
| if not %errorlevel% 0 exit /b %errorlevel% | |||
There was a problem hiding this comment.
Shouldn't it be if %errorlevel% neq 0 exit /b %errorlevel% ?
There was a problem hiding this comment.
Maybe that's more accurate.
Codecov Report
@@ Coverage Diff @@
## v0.x.x #731 +/- ##
=======================================
Coverage 91.34% 91.34%
=======================================
Files 65 65
Lines 5162 5167 +5
=======================================
+ Hits 4715 4720 +5
Misses 447 447
Continue to review full report at Codecov.
|
|
@AndrejMitrovic and me were discussing whether |
|
@TrustHenry : Can any of those be enabled, or do every single line fail ? |
|
#739 No errors will occur except for this issue. |
A build test error occurred in the window cmd environment, but the exit code is not returned. Returns only the last run result.
|
@TrustHenry you could add a That way we continue having proper Windows build tests and we can worry about fixing the linker issue later. |
|
That test is broken anyway, so merging this as is, and let's revisit when convenient: #650 |
A build test error occurred in the window cmd environment, but the exit code is not returned.
Returns only the last run result.