Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some portion of Transactions should include fees and data #26

Closed
omerfirmak opened this issue Dec 30, 2020 · 6 comments
Closed

Some portion of Transactions should include fees and data #26

omerfirmak opened this issue Dec 30, 2020 · 6 comments
Assignees
@hewison-chris @kchulj
Labels
type-enhancement Issue/PR is about an enhancement to an existing feature

Comments

@omerfirmak
Copy link
Contributor

To test the fee distribution on the live env, we need some of the generated transactions to include fees and/or data payload.
@kchulj kchulj added the type-enhancement Issue/PR is about an enhancement to an existing feature label Mar 4, 2021
@ferencdg ferencdg mentioned this issue May 18, 2021
Closed
@ferencdg
Copy link

after this is done, minimum fee bug can be fixed: bosagora/agora#2099

@kchulj kchulj self-assigned this May 27, 2021
@ferencdg ferencdg removed their assignment Jul 6, 2021
@ferencdg ferencdg mentioned this issue Jul 13, 2021
Closed
@Geod24
Copy link
Contributor

Geod24 commented Jul 19, 2021

The Agora side is ready, what's the ETA on this ?

@kchulj
Copy link

kchulj commented Jul 19, 2021

The Agora side is ready, what's the ETA on this ?

ETA is tomorrow as of right now.

This was referenced Jul 23, 2021
Merged
Closed
@kchulj kchulj mentioned this issue Aug 18, 2021
Merged
@Geod24
Copy link
Contributor

Geod24 commented Aug 20, 2021

Is this done ?

@kchulj
Copy link

kchulj commented Aug 20, 2021

Is this done ?

This issue should have been solved by #128 .
@hewison-chris What do you think?

@hewison-chris
Copy link
Contributor

We didn't add data but the fees are now included by the TxBuilder using default fee rate.

@Geod24 Geod24 closed this as completed Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hewison-chris hewison-chris

@kchulj kchulj

Labels
type-enhancement Issue/PR is about an enhancement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add fees to transactions kchulj/faucet
5 participants
@Geod24 @omerfirmak @hewison-chris @kchulj @ferencdg