Use updated sign method
#128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smaller coin units should be filtered, so that there is enough amount in the output for the fee deduction.
|
This is draft until it is merged step-by-step with bosagora/agora#2370. |
hewison-chris
approved these changes
Aug 18, 2021
source/faucet/main.d
Outdated
| Transaction tx = txb | ||
| .sign(OutputType.Payment, 0, &this.keyUnlocker); | ||
| Transaction tx = txb.unlockSigner(&this.keyUnlocker) | ||
| .sign(OutputType.Payment, 0); |
source/faucet/main.d
Outdated
| @@ -274,7 +274,8 @@ public class Faucet : FaucetAPI | |||
| auto builder = TxBuilder( | |||
| secret_keys.byKey().drop(uniform(0, secret_keys.length, rndGen)).front()); | |||
| builder.attach(utxo_rng); | |||
| return builder.sign(OutputType.Payment, 0, &this.keyUnlocker); | |||
| return builder.unlockSigner(&this.keyUnlocker) | |||
| .sign(OutputType.Payment, 0); | |||
There was a problem hiding this comment.
Before the .sign. Should be like line 275.
kchulj
force-pushed
the
unlock
branch
2 times, most recently
from
8b16aac
to
6052dc2
Compare
hewison-chris
suggested changes
Aug 19, 2021
Transition from the deprecated sign to the new sign.
Updated |
Geod24
approved these changes
Aug 19, 2021
Geod24
reviewed
Aug 19, 2021
Comment on lines
244
to
+247
| return utxo_rng | ||
| .filter!(tup => tup.value.output.value >= Amount(count)) | ||
| .filter!(tup => tup.value.output.value >= minInputValuePerOutput * count) | ||
| .map!(tup => TxBuilder(tup.value.output, tup.key)) | ||
| .map!(txb => txb.split( | ||
| .map!(txb => txb.unlockSigner(&this.keyUnlocker).split( |
There was a problem hiding this comment.
I think we should be a bit smarter here (attaching to multiple UTXOs) but for now this works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transition from the
deprecatedsignto the newsign.Also includes a commit which filters
Amounts less than5,000,000.Smaller coin units should be filtered, so that there is enough amount in the output for the fee deduction.
Part of #26