Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement delayed transactions (again) #677

Closed
wants to merge 2 commits into from
Closed

Implement delayed transactions (again) #677

wants to merge 2 commits into from

Conversation

Geod24
Copy link
Contributor

@Geod24 Geod24 commented Nov 8, 2018

Originally #624 but was reverted in #671

With the introduction of delayed operations,
it is no more necessary to do an unfreezing after the unfreezing request have been done,
greatly simplifying the process for users.
@codecov-io
Copy link

codecov-io commented Nov 8, 2018

Codecov Report

Merging #677 into master will increase coverage by 0.76%.
The diff coverage is 59.75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #677      +/-   ##
=========================================
+ Coverage   63.63%   64.4%   +0.76%     
=========================================
  Files         131     130       -1     
  Lines        8233    8127     -106     
=========================================
- Hits         5239    5234       -5     
+ Misses       2412    2310     -102     
- Partials      582     583       +1
Flag Coverage Δ
#integration_tests_node 43.96% <29.26%> (+0.68%) ⬆️
#unittests 53.86% <58.53%> (+0.28%) ⬆️
Impacted Files Coverage Δ
lib/node/runner/checker_ballot_transaction.go 64.13% <ø> (+5.07%) ⬆️
lib/node/runner/test.go 82.85% <ø> (-4.41%) ⬇️
cmd/sebak/cmd/wallet.go 66.66% <ø> (-3.34%) ⬇️
lib/transaction/operation/operation.go 50.53% <ø> (+3.53%) ⬆️
lib/transaction/test.go 9.63% <ø> (+3.02%) ⬆️
lib/sync/validator.go 14.18% <0%> (ø) ⬆️
lib/transaction/pool.go 83.33% <100%> (+0.25%) ⬆️
lib/node/runner/checker.go 60.05% <100%> (+0.1%) ⬆️
lib/node/runner/finish_ballot.go 48.01% <37.5%> (-5.28%) ⬇️
lib/transaction/pending.go 82.05% <82.05%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f4ceb6...c530b82. Read the comment docs.

@Geod24 Geod24 closed this Feb 21, 2019
@Geod24 Geod24 deleted the delayed-transactions branch February 21, 2019 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants