#659 Adaptable Discoverying Nodes #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test cases will be added. |
spikeekips
requested review from
Charleslee522,
kfangw,
anarcher,
outsideris and
zzim2x
|
There's a lot to test. And it needs a rebase. Could you update ? I'll focus on reviewing/testing this tomorrow so we can get it merged quickly. |
|
Thanks l, I will. |
spikeekips
force-pushed
the
659-take1-connect-with-message
branch
from
c8138bd
to
aa9dc93
Compare
spikeekips
force-pushed
the
659-take1-connect-with-message
branch
3 times, most recently
from
1712e1f
to
d0b435a
Compare
Codecov Report
@@ Coverage Diff @@
## master #705 +/- ##
==========================================
- Coverage 60.43% 60.25% -0.18%
==========================================
Files 151 153 +2
Lines 10347 10708 +361
==========================================
+ Hits 6253 6452 +199
- Misses 3394 3522 +128
- Partials 700 734 +34
Continue to review full report at Codecov.
|
spikeekips
changed the title
|
Entirely newly rewrote. Please continue to review |
spikeekips
force-pushed
the
659-take1-connect-with-message
branch
from
d0b435a
to
8ceda36
Compare
spikeekips
force-pushed
the
659-take1-connect-with-message
branch
from
8ceda36
to
9906075
Compare
spikeekips
force-pushed
the
659-take1-connect-with-message
branch
from
9906075
to
e5ffac0
Compare
kfangw
reviewed
Dec 18, 2018
This was referenced Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adaptable Connecting Nodes
Resolves #659
At this time, a node must know these things about its validators,
When one of the endpoints is updated, all the nodes in the network must be restarted with the updated endpoints. This will be a painful job for maintanence.
This patch will solve this problem and new endpoint of validators will be updated without downtime.
Changes
--validatorsonly with public addressThe current way to set
--validatorsis,--validators "self https://127.0.0.1:2822?address=G..W&alias=node2 https://127.0.0.1:2823/?address=G..4&alias=node3 https://127.0.0.1:2824/?address=G..O&alias=node4"The new way is,
--validators "self G..W G..4 G..O"Node just knows only the public address, the variable information like endpoint and alias are removed.
The environment variable also can be set,
New option,
--discoveryInstead of setting endpoint in
--validatorsoption, using--discoverynode will try to discover the validators. When a node starts, the node will sendnetwork.DiscoveryMessageto--discoveryvalues. Each node sends and receivesnetwork.DiscoveryMessages, the node can be started until the number of discovered validators is over consensus threshold.--discoveryalso can be set by an environment variable,SEBAK_DISCOVERY, multiple values can be separated by empty space.Omitting
-discoveryoption also be possible. Without--discoverynode will just waitnetwork.DiscoveryMessagefrom other nodes.WatcherMode
Watcher does not care about the validator, it just needs the target node to watch. Watcher will use
--discoveryinstead of--validators, the node address will be fetched from the node info of--discoverynode. At this process, the remote node info is compared with watcher; the network id and initial balance are matched.Minor changes
node.LocalNode.Endpoint()will return ifpublishEndpointis setnode.LocalNode.ClearValidators()will make emptyvalidatorsEtc
This patch was severely tested in integration test :)