Allow watch with Watcher node #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #860 +/- ##
==========================================
+ Coverage 60.76% 60.77% +<.01%
==========================================
Files 153 153
Lines 10288 10289 +1
==========================================
+ Hits 6252 6253 +1
Misses 3351 3351
Partials 685 685
Continue to review full report at Codecov.
|
spikeekips
approved these changes
Dec 2, 2018
| @@ -86,6 +86,7 @@ func (c *Config) NewFetcher() Fetcher { | |||
| c.localNode, | |||
| func(f *BlockFetcher) { | |||
| f.fetchTimeout = c.FetchTimeout | |||
| f.retryInterval = c.RetryInterval | |||
There was a problem hiding this comment.
One question. What is it for? :)
kfangw
approved these changes
Dec 3, 2018
anarcher
force-pushed
the
watch-watcher
branch
from
302851b
to
97660e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Issue
Background
I think that it's not bad topology. With this topology, we can protect our consensus nodes. (maybe)
Solution
Possible Drawbacks