-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
load CommonAccountAddress with sync start #883
Conversation
Codecov Report
@@ Coverage Diff @@
## master #883 +/- ##
========================================
+ Coverage 60.4% 60.5% +0.1%
========================================
Files 153 153
Lines 10713 10724 +11
========================================
+ Hits 6471 6489 +18
+ Misses 3509 3501 -8
- Partials 733 734 +1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #883 +/- ##
========================================
+ Coverage 60.4% 60.5% +0.1%
========================================
Files 153 153
Lines 10713 10724 +11
========================================
+ Hits 6471 6489 +18
+ Misses 3509 3501 -8
- Partials 733 734 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
Github Issue
common/Config.CommonAccountAddress
is not loaded whencommon.Config
is created. So sync has to loadCommonAccountAddress
and add it toConfig.CommonAccountAddress
Background
Block height 348204 has
inflation-pf
operation, and this operation validation needscommon.Config.CommonAccountAddress
.Solution
sync/Config
loadsCommonAccountAddress
and add it tocommon/Config.CommonAccountAddress
.Possible Drawbacks
IHMO,
common/Config
itself loads it's own attributes when it is created makes sense.